2013-03-01 11:17:38

by Sander Eikelenboom

[permalink] [raw]
Subject: [PATCH] libata-acpi.c: fix copy and paste mistake in ata_acpi_register_power_resource

Fix a copy and paste mistake introduced in:

commit bc9b6407bd6df3ab7189e5622816bbc11ae9d2d8
"ACPI / PM: Rework the handling of devices depending on power resources"

Signed-off-by: Sander Eikelenboom <[email protected]>
---
drivers/ata/libata-acpi.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/ata/libata-acpi.c b/drivers/ata/libata-acpi.c
index 0ea1018..cb3eab6d 100644
--- a/drivers/ata/libata-acpi.c
+++ b/drivers/ata/libata-acpi.c
@@ -1027,7 +1027,7 @@ static void ata_acpi_register_power_resource(struct ata_device *dev)

handle = ata_dev_acpi_handle(dev);
if (handle)
- acpi_dev_pm_remove_dependent(handle, &sdev->sdev_gendev);
+ acpi_dev_pm_add_dependent(handle, &sdev->sdev_gendev);
}

static void ata_acpi_unregister_power_resource(struct ata_device *dev)
--
1.7.2.5


2013-03-01 14:33:06

by Sedat Dilek

[permalink] [raw]
Subject: Re: [PATCH] libata-acpi.c: fix copy and paste mistake in ata_acpi_register_power_resource

Original posting see [1].

Good catch!

Latest Linux-Next (next-20130301) is also affected!

The patch can be easily grabbed from [2].

Sander pointed to the mismatch in [3].

- Sedat -

[1] http://marc.info/?l=linux-kernel&m=136213666529000&w=2
[2] https://patchwork.kernel.org/patch/2200901/
[3] http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commitdiff;h=bc9b6407bd6df3ab7189e5622816bbc11ae9d2d8#patch5

2013-03-01 16:27:46

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [PATCH] libata-acpi.c: fix copy and paste mistake in ata_acpi_register_power_resource

On Friday, March 01, 2013 12:16:42 PM Sander Eikelenboom wrote:
> Fix a copy and paste mistake introduced in:
>
> commit bc9b6407bd6df3ab7189e5622816bbc11ae9d2d8
> "ACPI / PM: Rework the handling of devices depending on power resources"
>
> Signed-off-by: Sander Eikelenboom <[email protected]>

Acked-by: Rafael J. Wysocki <[email protected]>

> ---
> drivers/ata/libata-acpi.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/ata/libata-acpi.c b/drivers/ata/libata-acpi.c
> index 0ea1018..cb3eab6d 100644
> --- a/drivers/ata/libata-acpi.c
> +++ b/drivers/ata/libata-acpi.c
> @@ -1027,7 +1027,7 @@ static void ata_acpi_register_power_resource(struct ata_device *dev)
>
> handle = ata_dev_acpi_handle(dev);
> if (handle)
> - acpi_dev_pm_remove_dependent(handle, &sdev->sdev_gendev);
> + acpi_dev_pm_add_dependent(handle, &sdev->sdev_gendev);
> }
>
> static void ata_acpi_unregister_power_resource(struct ata_device *dev)
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

2013-03-04 22:15:09

by Jeff Garzik

[permalink] [raw]
Subject: Re: [PATCH] libata-acpi.c: fix copy and paste mistake in ata_acpi_register_power_resource

On 03/01/2013 06:16 AM, Sander Eikelenboom wrote:
> Fix a copy and paste mistake introduced in:
>
> commit bc9b6407bd6df3ab7189e5622816bbc11ae9d2d8
> "ACPI / PM: Rework the handling of devices depending on power resources"
>
> Signed-off-by: Sander Eikelenboom <[email protected]>
> ---
> drivers/ata/libata-acpi.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)

applied