2021-02-08 21:55:40

by Sedat Dilek

[permalink] [raw]
Subject: [PATCH] x86: entry: Remove _TIF_SINGLESTEP define leftover

After commit 6342adcaa683 ("entry: Ensure trap after single-step on
system call return") a _TIF_SINGLESTEP define is obsolete for arch/x86.

So, remove the leftover in arch/x86/include/asm/thread_info.h file.

Fixes: 6342adcaa683 ("entry: Ensure trap after single-step on system call return"
CC: Kyle Huey <[email protected]>
Signed-off-by: Sedat Dilek <[email protected]>
---
arch/x86/include/asm/thread_info.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/x86/include/asm/thread_info.h b/arch/x86/include/asm/thread_info.h
index 0d751d5da702..8861967e0305 100644
--- a/arch/x86/include/asm/thread_info.h
+++ b/arch/x86/include/asm/thread_info.h
@@ -101,7 +101,6 @@ struct thread_info {
#define _TIF_NOTIFY_RESUME (1 << TIF_NOTIFY_RESUME)
#define _TIF_SIGPENDING (1 << TIF_SIGPENDING)
#define _TIF_NEED_RESCHED (1 << TIF_NEED_RESCHED)
-#define _TIF_SINGLESTEP (1 << TIF_SINGLESTEP)
#define _TIF_SSBD (1 << TIF_SSBD)
#define _TIF_SPEC_IB (1 << TIF_SPEC_IB)
#define _TIF_SPEC_FORCE_UPDATE (1 << TIF_SPEC_FORCE_UPDATE)
--
2.30.0


2021-02-08 22:04:21

by Kyle Huey

[permalink] [raw]
Subject: Re: [PATCH] x86: entry: Remove _TIF_SINGLESTEP define leftover

Looks good to me.

- Kyle

On Mon, Feb 8, 2021 at 1:43 PM Sedat Dilek <[email protected]> wrote:
>
> After commit 6342adcaa683 ("entry: Ensure trap after single-step on
> system call return") a _TIF_SINGLESTEP define is obsolete for arch/x86.
>
> So, remove the leftover in arch/x86/include/asm/thread_info.h file.
>
> Fixes: 6342adcaa683 ("entry: Ensure trap after single-step on system call return"
> CC: Kyle Huey <[email protected]>
> Signed-off-by: Sedat Dilek <[email protected]>
> ---
> arch/x86/include/asm/thread_info.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/include/asm/thread_info.h b/arch/x86/include/asm/thread_info.h
> index 0d751d5da702..8861967e0305 100644
> --- a/arch/x86/include/asm/thread_info.h
> +++ b/arch/x86/include/asm/thread_info.h
> @@ -101,7 +101,6 @@ struct thread_info {
> #define _TIF_NOTIFY_RESUME (1 << TIF_NOTIFY_RESUME)
> #define _TIF_SIGPENDING (1 << TIF_SIGPENDING)
> #define _TIF_NEED_RESCHED (1 << TIF_NEED_RESCHED)
> -#define _TIF_SINGLESTEP (1 << TIF_SINGLESTEP)
> #define _TIF_SSBD (1 << TIF_SSBD)
> #define _TIF_SPEC_IB (1 << TIF_SPEC_IB)
> #define _TIF_SPEC_FORCE_UPDATE (1 << TIF_SPEC_FORCE_UPDATE)
> --
> 2.30.0
>

2021-02-13 19:22:56

by Sedat Dilek

[permalink] [raw]
Subject: Re: [PATCH] x86: entry: Remove _TIF_SINGLESTEP define leftover

On Mon, Feb 8, 2021 at 11:01 PM Kyle Huey <[email protected]> wrote:
>
> Looks good to me.
>

Any other comments on this patch v2?

Thanks.

- Sedat -

> - Kyle
>
> On Mon, Feb 8, 2021 at 1:43 PM Sedat Dilek <[email protected]> wrote:
> >
> > After commit 6342adcaa683 ("entry: Ensure trap after single-step on
> > system call return") a _TIF_SINGLESTEP define is obsolete for arch/x86.
> >
> > So, remove the leftover in arch/x86/include/asm/thread_info.h file.
> >
> > Fixes: 6342adcaa683 ("entry: Ensure trap after single-step on system call return"
> > CC: Kyle Huey <[email protected]>
> > Signed-off-by: Sedat Dilek <[email protected]>
> > ---
> > arch/x86/include/asm/thread_info.h | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/x86/include/asm/thread_info.h b/arch/x86/include/asm/thread_info.h
> > index 0d751d5da702..8861967e0305 100644
> > --- a/arch/x86/include/asm/thread_info.h
> > +++ b/arch/x86/include/asm/thread_info.h
> > @@ -101,7 +101,6 @@ struct thread_info {
> > #define _TIF_NOTIFY_RESUME (1 << TIF_NOTIFY_RESUME)
> > #define _TIF_SIGPENDING (1 << TIF_SIGPENDING)
> > #define _TIF_NEED_RESCHED (1 << TIF_NEED_RESCHED)
> > -#define _TIF_SINGLESTEP (1 << TIF_SINGLESTEP)
> > #define _TIF_SSBD (1 << TIF_SSBD)
> > #define _TIF_SPEC_IB (1 << TIF_SPEC_IB)
> > #define _TIF_SPEC_FORCE_UPDATE (1 << TIF_SPEC_FORCE_UPDATE)
> > --
> > 2.30.0
> >