2014-11-10 16:21:04

by Jim Davis

[permalink] [raw]
Subject: randconfig build error with next-20141110, in drivers/platform/x86/hp_accel.c

Building with the attached random configuration file,

drivers/built-in.o: In function `lis3lv02d_remove':
/home/jim/linux/drivers/platform/x86/hp_accel.c:389: undefined
reference to `i8042_remove_filter'
drivers/built-in.o: In function `lis3lv02d_add':
/home/jim/linux/drivers/platform/x86/hp_accel.c:370: undefined
reference to `i8042_install_filter'
make: *** [vmlinux] Error 1


Attachments:
randconfig-1415624182.txt (80.70 kB)

2014-11-10 17:07:26

by Giedrius Statkevičius

[permalink] [raw]
Subject: Re: randconfig build error with next-20141110, in drivers/platform/x86/hp_accel.c

Hi Jim,

On 2014.11.10 18:20, Jim Davis wrote:
> Building with the attached random configuration file,
>
> drivers/built-in.o: In function `lis3lv02d_remove':
> /home/jim/linux/drivers/platform/x86/hp_accel.c:389: undefined
> reference to `i8042_remove_filter'
> drivers/built-in.o: In function `lis3lv02d_add':
> /home/jim/linux/drivers/platform/x86/hp_accel.c:370: undefined
> reference to `i8042_install_filter'
> make: *** [vmlinux] Error 1
>

Oops, sorry. Forgot to add a depend on i8042 per this patch in Kconfig:
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=a4c724d0723b078e4ab4670e557cda1795036a7a

This patch should fix it. After applying and using your .config I
compiled the kernel without those undefined references. Should I make a
new thread where it's submitted in the proper form?

thanks,
Giedrius
---
drivers/platform/x86/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 4dcfb71..7d146e68 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -202,6 +202,7 @@ config TC1100_WMI
config HP_ACCEL
tristate "HP laptop accelerometer"
depends on INPUT && ACPI
+ depends on SERIO_I8042
select SENSORS_LIS3LV02D
select NEW_LEDS
select LEDS_CLASS
--
2.1.3

2014-11-10 18:04:31

by Darren Hart

[permalink] [raw]
Subject: Re: randconfig build error with next-20141110, in drivers/platform/x86/hp_accel.c



On November 10, 2014 8:59:46 AM PST, Giedrius Statkevicius <[email protected]> wrote:
>Hi Jim,
>
>On 2014.11.10 18:20, Jim Davis wrote:
>> Building with the attached random configuration file,
>>
>> drivers/built-in.o: In function `lis3lv02d_remove':
>> /home/jim/linux/drivers/platform/x86/hp_accel.c:389: undefined
>> reference to `i8042_remove_filter'
>> drivers/built-in.o: In function `lis3lv02d_add':
>> /home/jim/linux/drivers/platform/x86/hp_accel.c:370: undefined
>> reference to `i8042_install_filter'
>> make: *** [vmlinux] Error 1
>>
>
>Oops, sorry. Forgot to add a depend on i8042 per this patch in Kconfig:
>https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=a4c724d0723b078e4ab4670e557cda1795036a7a
>
>This patch should fix it. After applying and using your .config I
>compiled the kernel without those undefined references. Should I make a
>new thread where it's submitted in the proper form?

Yes please.


--
Sent from my Android device with K-9 Mail. Please excuse my brevity.