2020-03-30 11:03:59

by Yue Haibing

Subject: [PATCH -next] RDMA/bnxt_re: make bnxt_re_ib_init static

Fix sparse warning:

drivers/infiniband/hw/bnxt_re/main.c:1313:5:
warning: symbol 'bnxt_re_ib_init' was not declared. Should it be static?

Signed-off-by: YueHaibing <[email protected]>
---
drivers/infiniband/hw/bnxt_re/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/bnxt_re/main.c b/drivers/infiniband/hw/bnxt_re/main.c
index 4a8fb1ad74a8..b12fbc857f94 100644
--- a/drivers/infiniband/hw/bnxt_re/main.c
+++ b/drivers/infiniband/hw/bnxt_re/main.c
@@ -1310,7 +1310,7 @@ static void bnxt_re_query_hwrm_intf_version(struct bnxt_re_dev *rdev)
le16_to_cpu(resp.hwrm_intf_patch);
}

-int bnxt_re_ib_init(struct bnxt_re_dev *rdev)
+static int bnxt_re_ib_init(struct bnxt_re_dev *rdev)
{
int rc = 0;
u32 event;
--
2.17.1

2020-03-30 12:18:32

by Selvin Xavier

Subject: Re: [PATCH -next] RDMA/bnxt_re: make bnxt_re_ib_init static

On Mon, Mar 30, 2020 at 4:33 PM YueHaibing <[email protected]> wrote:
>
> Fix sparse warning:
>
> drivers/infiniband/hw/bnxt_re/main.c:1313:5:
> warning: symbol 'bnxt_re_ib_init' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <[email protected]>
Acked-by: Selvin Xavier <[email protected]>

Thanks,
Selvin Xavier

2020-03-30 18:08:08

by Jason Gunthorpe

Subject: Re: [PATCH -next] RDMA/bnxt_re: make bnxt_re_ib_init static

On Mon, Mar 30, 2020 at 07:02:19PM +0800, YueHaibing wrote:
> Fix sparse warning:
>
> drivers/infiniband/hw/bnxt_re/main.c:1313:5:
> warning: symbol 'bnxt_re_ib_init' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <[email protected]>
> Acked-by: Selvin Xavier <[email protected]>
> ---
> drivers/infiniband/hw/bnxt_re/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to for-next, thanks

Jason