2013-06-13 15:23:08

by Tommi Rantala

[permalink] [raw]
Subject: sound/oss/ad1848.c:2867:32: warning: ‘id_table’ defined but not used

Hello, I'm seeing the following compiler warning, does it look useful?
I'm doing a v3.10-rc5 x86-64 build.

/build/linux/sound/oss/ad1848.c:2867:32: warning: ?id_table? defined
but not used [-Wunused-variable]

$ gcc --version
gcc (Ubuntu/Linaro 4.7.3-1ubuntu1) 4.7.3
Copyright (C) 2012 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

config:
http://fpaste.org/18443/13711363/

Tommi


2013-06-17 07:56:13

by Takashi Iwai

[permalink] [raw]
Subject: Re: sound/oss/ad1848.c:2867:32: warning: ‘id_table’ defined but not used

At Thu, 13 Jun 2013 18:23:02 +0300,
Tommi Rantala wrote:
>
> Hello, I'm seeing the following compiler warning, does it look useful?
> I'm doing a v3.10-rc5 x86-64 build.
>
> /build/linux/sound/oss/ad1848.c:2867:32: warning: ‘id_table’ defined
> but not used [-Wunused-variable]
>
> $ gcc --version
> gcc (Ubuntu/Linaro 4.7.3-1ubuntu1) 4.7.3
> Copyright (C) 2012 Free Software Foundation, Inc.
> This is free software; see the source for copying conditions. There is NO
> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
>
> config:
> http://fpaste.org/18443/13711363/

It's because CONFIG_ISAPNP isn't set (it's optional). You can add
ifdef to hide the warning, but it makes the code uglier, OTOH.

Since this driver is a legacy one and almost no one uses it, better to
save your time for more useful things, I'd say :)


thanks,

Takashi