2021-09-20 16:09:10

by Krzysztof Kozlowski

Subject: [RESEND PATCH v2 2/5] riscv: dts: sifive: fix Unleashed board compatible

Add missing sifive,fu540 compatible to fix dtbs_check warnings:

arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dt.yaml: /: compatible: 'oneOf' conditional failed, one must be fixed:
['sifive,hifive-unleashed-a00', 'sifive,fu540-c000'] is too short
'sifive,hifive-unleashed-a00' is not one of ['sifive,hifive-unmatched-a00']
'sifive,fu740-c000' was expected

Signed-off-by: Krzysztof Kozlowski <[email protected]>

---

Changes since v1:
1. None
---
arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
index 633b31b6e25c..2b4af7b4cc2f 100644
--- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
+++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
@@ -11,7 +11,8 @@ / {
#address-cells = <2>;
#size-cells = <2>;
model = "SiFive HiFive Unleashed A00";
- compatible = "sifive,hifive-unleashed-a00", "sifive,fu540-c000";
+ compatible = "sifive,hifive-unleashed-a00", "sifive,fu540-c000",
+ "sifive,fu540";

chosen {
stdout-path = "serial0";
--
2.30.2

2021-10-11 16:40:20

by Krzysztof Kozlowski

Subject: Re: [RESEND PATCH v2 2/5] riscv: dts: sifive: fix Unleashed board compatible

On 20/09/2021 15:02, Krzysztof Kozlowski wrote:
> Add missing sifive,fu540 compatible to fix dtbs_check warnings:
>
> arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dt.yaml: /: compatible: 'oneOf' conditional failed, one must be fixed:
> ['sifive,hifive-unleashed-a00', 'sifive,fu540-c000'] is too short
> 'sifive,hifive-unleashed-a00' is not one of ['sifive,hifive-unmatched-a00']
> 'sifive,fu740-c000' was expected
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
>
> Changes since v1:
> 1. None
> ---
> arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>

Anyone maintains RISC-V boards? I got no replies for the first patch,
then for the second version and finally for the resend.

If no one is interested, I'll pick it up.

Best regards,
Krzysztof

2021-10-12 04:41:00

by Alexandre Ghiti

Subject: Re: [RESEND PATCH v2 2/5] riscv: dts: sifive: fix Unleashed board compatible

On Mon, Sep 20, 2021 at 3:05 PM Krzysztof Kozlowski
<[email protected]> wrote:
>
> Add missing sifive,fu540 compatible to fix dtbs_check warnings:
>
> arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dt.yaml: /: compatible: 'oneOf' conditional failed, one must be fixed:
> ['sifive,hifive-unleashed-a00', 'sifive,fu540-c000'] is too short
> 'sifive,hifive-unleashed-a00' is not one of ['sifive,hifive-unmatched-a00']
> 'sifive,fu740-c000' was expected
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
>
> Changes since v1:
> 1. None
> ---
> arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
> index 633b31b6e25c..2b4af7b4cc2f 100644
> --- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
> +++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
> @@ -11,7 +11,8 @@ / {
> #address-cells = <2>;
> #size-cells = <2>;
> model = "SiFive HiFive Unleashed A00";
> - compatible = "sifive,hifive-unleashed-a00", "sifive,fu540-c000";
> + compatible = "sifive,hifive-unleashed-a00", "sifive,fu540-c000",
> + "sifive,fu540";
>
> chosen {
> stdout-path = "serial0";
> --
> 2.30.2
>
>

This looks good to me, you can add:

Reviewed-by: Alexandre Ghiti <[email protected]>
Tested-by: Alexandre Ghiti <[email protected]>

Thanks,

Alex

> _______________________________________________
> linux-riscv mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-riscv