2021-06-11 02:29:33

by Shengjiu Wang

[permalink] [raw]
Subject: Re: [PATCH] ASoC:fsl_spdif:Remove superfluous error message around platform_get_irq()

On Thu, Jun 10, 2021 at 12:02 PM Zhongjun Tan <[email protected]> wrote:
>
> From: Tan Zhongjun <[email protected]>
>
> The platform_get_irq() prints error message telling that interrupt is
> missing, hence there is no need to duplicated that message.
>
> Signed-off-by: Tan Zhongjun <[email protected]>

Acked-by: Shengjiu Wang <[email protected]>

> ---
> sound/soc/fsl/fsl_spdif.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c
> index 2a76714eb8e6..29cefd459241 100644
> --- a/sound/soc/fsl/fsl_spdif.c
> +++ b/sound/soc/fsl/fsl_spdif.c
> @@ -1368,10 +1368,8 @@ static int fsl_spdif_probe(struct platform_device *pdev)
>
> for (i = 0; i < spdif_priv->soc->interrupts; i++) {
> irq = platform_get_irq(pdev, i);
> - if (irq < 0) {
> - dev_err(&pdev->dev, "no irq for node %s\n", pdev->name);
> + if (irq < 0)
> return irq;
> - }
>
> ret = devm_request_irq(&pdev->dev, irq, spdif_isr, 0,
> dev_name(&pdev->dev), spdif_priv);
> --
> 2.17.1
>