2020-08-14 12:13:51

by Abel Vesa

Subject: [PATCH v2 10/17] Documentation: bindings: clk: Add bindings for i.MX BLK_CTRL

Document the i.MX BLK_CTRL with its devicetree properties.

Signed-off-by: Abel Vesa <[email protected]>
---
.../bindings/clock/fsl,imx-blk-ctrl.yaml | 60 ++++++++++++++++++++++
1 file changed, 60 insertions(+)
create mode 100644 Documentation/devicetree/bindings/clock/fsl,imx-blk-ctrl.yaml

diff --git a/Documentation/devicetree/bindings/clock/fsl,imx-blk-ctrl.yaml b/Documentation/devicetree/bindings/clock/fsl,imx-blk-ctrl.yaml
new file mode 100644
index 00000000..b47590c
--- /dev/null
+++ b/Documentation/devicetree/bindings/clock/fsl,imx-blk-ctrl.yaml
@@ -0,0 +1,60 @@
+# SPDX-License-Identifier: (GPL-2.0-only)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/clock/fsl,imx-blk-ctrl.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NXP i.MX BLK_CTRL
+
+maintainers:
+ - Abel Vesa <[email protected]>
+
+description:
+ i.MX BLK_CTRL is a conglomerate of different GPRs that are
+ dedicated to a specific subsystem. Because it usually contains
+ clocks amongst other things, it needs access to the i.MX clocks
+ API. All the other functionalities it provides can work just fine
+ from the clock subsystem tree.
+
+properties:
+ compatible:
+ items:
+ - enum:
+ - fsl,imx8mp-audio-blk-ctrl
+ - fsl,imx8mp-hdmi-blk-ctrl
+ - fsl,imx8mp-media-blk-ctrl
+ - const: syscon
+
+ reg:
+ maxItems: 1
+
+ power-domains:
+ maxItems: 1
+
+ '#clock-cells':
+ const: 1
+
+ '#reset-cells':
+ const: 1
+
+required:
+ - compatible
+ - reg
+ - power-domains
+ - '#clock-cells'
+ - '#reset-cells'
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/imx8mp-clock.h>
+
+ audio_blk_ctrl: clock-controller@30e20000 {
+ compatible = "fsl,imx8mp-audio-blk-ctrl", "syscon";
+ reg = <0x30e20000 0x10000>;
+ power-domains = <&audiomix_pd>;
+
+ #clock-cells = <1>;
+ #reset-cells = <1>;
+ };
--
2.7.4

2020-08-17 08:24:10

by Dong Aisheng

Subject: Re: [PATCH v2 10/17] Documentation: bindings: clk: Add bindings for i.MX BLK_CTRL

On Fri, Aug 14, 2020 at 8:14 PM Abel Vesa <[email protected]> wrote:
>
> Document the i.MX BLK_CTRL with its devicetree properties.
>
> Signed-off-by: Abel Vesa <[email protected]>

Reviewed-by: Dong Aisheng <[email protected]>

Regards
Aisheng

2020-08-25 02:17:02

by Rob Herring

Subject: Re: [PATCH v2 10/17] Documentation: bindings: clk: Add bindings for i.MX BLK_CTRL

On Fri, Aug 14, 2020 at 03:09:19PM +0300, Abel Vesa wrote:
> Document the i.MX BLK_CTRL with its devicetree properties.
>
> Signed-off-by: Abel Vesa <[email protected]>
> ---
> .../bindings/clock/fsl,imx-blk-ctrl.yaml | 60 ++++++++++++++++++++++
> 1 file changed, 60 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/fsl,imx-blk-ctrl.yaml
>
> diff --git a/Documentation/devicetree/bindings/clock/fsl,imx-blk-ctrl.yaml b/Documentation/devicetree/bindings/clock/fsl,imx-blk-ctrl.yaml
> new file mode 100644
> index 00000000..b47590c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/fsl,imx-blk-ctrl.yaml
> @@ -0,0 +1,60 @@
> +# SPDX-License-Identifier: (GPL-2.0-only)

Dual license new bindings please:

(GPL-2.0-only OR BSD-2-Clause)

> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/fsl,imx-blk-ctrl.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP i.MX BLK_CTRL
> +
> +maintainers:
> + - Abel Vesa <[email protected]>
> +
> +description:
> + i.MX BLK_CTRL is a conglomerate of different GPRs that are
> + dedicated to a specific subsystem. Because it usually contains
> + clocks amongst other things, it needs access to the i.MX clocks
> + API. All the other functionalities it provides can work just fine
> + from the clock subsystem tree.
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - fsl,imx8mp-audio-blk-ctrl
> + - fsl,imx8mp-hdmi-blk-ctrl
> + - fsl,imx8mp-media-blk-ctrl
> + - const: syscon
> +
> + reg:
> + maxItems: 1
> +
> + power-domains:
> + maxItems: 1
> +
> + '#clock-cells':
> + const: 1
> +
> + '#reset-cells':
> + const: 1
> +
> +required:
> + - compatible
> + - reg
> + - power-domains
> + - '#clock-cells'
> + - '#reset-cells'
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/imx8mp-clock.h>
> +
> + audio_blk_ctrl: clock-controller@30e20000 {
> + compatible = "fsl,imx8mp-audio-blk-ctrl", "syscon";
> + reg = <0x30e20000 0x10000>;
> + power-domains = <&audiomix_pd>;
> +
> + #clock-cells = <1>;
> + #reset-cells = <1>;
> + };
> --
> 2.7.4
>