2021-02-19 16:04:27

by Abel Vesa

Subject: [RFC 05/19] devfreq: imx8m-ddrc: Change governor to powersave

By switching to powersave governor, we allow the imx8m-ddrc to always
run at minimum rate needed by all the running masters.

Signed-off-by: Abel Vesa <[email protected]>
---
drivers/devfreq/imx8m-ddrc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/devfreq/imx8m-ddrc.c b/drivers/devfreq/imx8m-ddrc.c
index bc82d3653bff..3a6c04ba4f2e 100644
--- a/drivers/devfreq/imx8m-ddrc.c
+++ b/drivers/devfreq/imx8m-ddrc.c
@@ -379,7 +379,7 @@ static int imx8m_ddrc_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
struct imx8m_ddrc *priv;
- const char *gov = DEVFREQ_GOV_USERSPACE;
+ const char *gov = DEVFREQ_GOV_POWERSAVE;
int ret;

priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
--
2.29.2

2021-02-26 14:49:54

by Chanwoo Choi

Subject: Re: [RFC 05/19] devfreq: imx8m-ddrc: Change governor to powersave

On 21. 2. 20. 오전 1:00, Abel Vesa wrote:
> By switching to powersave governor, we allow the imx8m-ddrc to always
> run at minimum rate needed by all the running masters.
>
> Signed-off-by: Abel Vesa <[email protected]>
> ---
> drivers/devfreq/imx8m-ddrc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/devfreq/imx8m-ddrc.c b/drivers/devfreq/imx8m-ddrc.c
> index bc82d3653bff..3a6c04ba4f2e 100644
> --- a/drivers/devfreq/imx8m-ddrc.c
> +++ b/drivers/devfreq/imx8m-ddrc.c
> @@ -379,7 +379,7 @@ static int imx8m_ddrc_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct imx8m_ddrc *priv;
> - const char *gov = DEVFREQ_GOV_USERSPACE;
> + const char *gov = DEVFREQ_GOV_POWERSAVE;
> int ret;
>
> priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
>

Acked-by: Chanwoo Choi <[email protected]>

Thanks,
Chanwoo Choi

2021-03-09 13:42:45

by Dong Aisheng

Subject: Re: [RFC 05/19] devfreq: imx8m-ddrc: Change governor to powersave

On Sat, Feb 20, 2021 at 12:03 AM Abel Vesa <[email protected]> wrote:
>
> By switching to powersave governor, we allow the imx8m-ddrc to always
> run at minimum rate needed by all the running masters.
>
> Signed-off-by: Abel Vesa <[email protected]>

Would you please help clarify a bit more why need use powersave by default?

Regards
Aisheng

> ---
> drivers/devfreq/imx8m-ddrc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/devfreq/imx8m-ddrc.c b/drivers/devfreq/imx8m-ddrc.c
> index bc82d3653bff..3a6c04ba4f2e 100644
> --- a/drivers/devfreq/imx8m-ddrc.c
> +++ b/drivers/devfreq/imx8m-ddrc.c
> @@ -379,7 +379,7 @@ static int imx8m_ddrc_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct imx8m_ddrc *priv;
> - const char *gov = DEVFREQ_GOV_USERSPACE;
> + const char *gov = DEVFREQ_GOV_POWERSAVE;
> int ret;
>
> priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> --
> 2.29.2
>