2020-08-14 12:13:15

by Abel Vesa

Subject: [PATCH v2 15/17] arm64: dts: imx8mp: Add audio_blk_ctrl node

Some of the features of the audio_ctrl will be used by some
different drivers in a way those drivers will know best, so adding the
syscon compatible we allow those to do just that. Only the resets
and the clocks are registered bit the clk-blk-ctrl driver.

Signed-off-by: Abel Vesa <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 16 ++++++++++++++++
1 file changed, 16 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index daa1769..dede0ae 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -736,6 +736,22 @@
};
};

+ aips5: bus@30c00000 {
+ compatible = "fsl,aips-bus", "simple-bus";
+ reg = <0x30c00000 0x400000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges;
+
+ audio_blk_ctrl: clock-controller@30e20000 {
+ compatible = "fsl,imx8mp-audio-blk-ctrl", "syscon";
+ reg = <0x30e20000 0x50C>;
+
+ #clock-cells = <1>;
+ #reset-cells = <1>;
+ };
+ };
+
gic: interrupt-controller@38800000 {
compatible = "arm,gic-v3";
reg = <0x38800000 0x10000>,
--
2.7.4

2020-08-18 11:48:23

by Dong Aisheng

Subject: Re: [PATCH v2 15/17] arm64: dts: imx8mp: Add audio_blk_ctrl node

On Fri, Aug 14, 2020 at 8:12 PM Abel Vesa <[email protected]> wrote:
>
> Some of the features of the audio_ctrl will be used by some
> different drivers in a way those drivers will know best, so adding the
> syscon compatible we allow those to do just that. Only the resets
> and the clocks are registered bit the clk-blk-ctrl driver.
>
> Signed-off-by: Abel Vesa <[email protected]>
> ---
> arch/arm64/boot/dts/freescale/imx8mp.dtsi | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index daa1769..dede0ae 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -736,6 +736,22 @@
> };
> };
>
> + aips5: bus@30c00000 {
> + compatible = "fsl,aips-bus", "simple-bus";
> + reg = <0x30c00000 0x400000>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + audio_blk_ctrl: clock-controller@30e20000 {
> + compatible = "fsl,imx8mp-audio-blk-ctrl", "syscon";
> + reg = <0x30e20000 0x50C>;

0x50c

> +

remove unnecessary blank line

Otherwise:
Reviewed-by: Dong Aisheng <[email protected]>

Regards
Aisheng

> + #clock-cells = <1>;
> + #reset-cells = <1>;
> + };
> + };
> +
> gic: interrupt-controller@38800000 {
> compatible = "arm,gic-v3";
> reg = <0x38800000 0x10000>,
> --
> 2.7.4
>

2020-08-19 20:34:59

by Abel Vesa

Subject: Re: [PATCH v2 15/17] arm64: dts: imx8mp: Add audio_blk_ctrl node

On 20-08-18 19:32:05, Dong Aisheng wrote:
> On Fri, Aug 14, 2020 at 8:12 PM Abel Vesa <[email protected]> wrote:
> >
> > Some of the features of the audio_ctrl will be used by some
> > different drivers in a way those drivers will know best, so adding the
> > syscon compatible we allow those to do just that. Only the resets
> > and the clocks are registered bit the clk-blk-ctrl driver.
> >
> > Signed-off-by: Abel Vesa <[email protected]>
> > ---
> > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 16 ++++++++++++++++
> > 1 file changed, 16 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > index daa1769..dede0ae 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > @@ -736,6 +736,22 @@
> > };
> > };
> >
> > + aips5: bus@30c00000 {
> > + compatible = "fsl,aips-bus", "simple-bus";
> > + reg = <0x30c00000 0x400000>;
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + ranges;
> > +
> > + audio_blk_ctrl: clock-controller@30e20000 {
> > + compatible = "fsl,imx8mp-audio-blk-ctrl", "syscon";
> > + reg = <0x30e20000 0x50C>;
>
> 0x50c
>

Will do.

> > +
>
> remove unnecessary blank line
>

Will do.

> Otherwise:
> Reviewed-by: Dong Aisheng <[email protected]>
>
> Regards
> Aisheng
>
> > + #clock-cells = <1>;
> > + #reset-cells = <1>;
> > + };
> > + };
> > +
> > gic: interrupt-controller@38800000 {
> > compatible = "arm,gic-v3";
> > reg = <0x38800000 0x10000>,
> > --
> > 2.7.4
> >