On Sun, Mar 20, 2022 at 8:44 AM Tong Zhang <[email protected]> wrote:
>
> Regulator should be disabled in error path as mentioned in _regulator_put().
> Also disable accel if gyro cannot be enabled.
>
> [ 16.233604] WARNING: CPU: 0 PID: 2177 at drivers/regulator/core.c:2257 _regulator_put
> [ 16.240453] Call Trace:
> [ 16.240572] <TASK>
> [ 16.240676] regulator_put+0x26/0x40
> [ 16.240853] regulator_bulk_free+0x26/0x50
> [ 16.241050] release_nodes+0x3f/0x70
> [ 16.241225] devres_release_group+0x147/0x1c0
> [ 16.241441] ? bmi160_core_probe+0x175/0x3a0 [bmi160_core]
Haven't I given you a tag?
--
With Best Regards,
Andy Shevchenko
On Mon, Mar 21, 2022 at 1:28 AM Andy Shevchenko
<[email protected]> wrote:
>
> On Sun, Mar 20, 2022 at 8:44 AM Tong Zhang <[email protected]> wrote:
> >
> > Regulator should be disabled in error path as mentioned in _regulator_put().
> > Also disable accel if gyro cannot be enabled.
> >
> > [ 16.233604] WARNING: CPU: 0 PID: 2177 at drivers/regulator/core.c:2257 _regulator_put
> > [ 16.240453] Call Trace:
> > [ 16.240572] <TASK>
> > [ 16.240676] regulator_put+0x26/0x40
> > [ 16.240853] regulator_bulk_free+0x26/0x50
> > [ 16.241050] release_nodes+0x3f/0x70
> > [ 16.241225] devres_release_group+0x147/0x1c0
> > [ 16.241441] ? bmi160_core_probe+0x175/0x3a0 [bmi160_core]
>
> Haven't I given you a tag?
>
> --
> With Best Regards,
> Andy Shevchenko
Hi Any, Thank you for reviewing the patch. I appreciate it.
I thought I would need another tag since this patch is a v2.
Sorry for this back and forth. Have a great one.
Thanks,
- Tong
On Mon, Mar 21, 2022 at 5:53 PM Tong Zhang <[email protected]> wrote:
> On Mon, Mar 21, 2022 at 1:28 AM Andy Shevchenko
> <[email protected]> wrote:
> > On Sun, Mar 20, 2022 at 8:44 AM Tong Zhang <[email protected]> wrote:
...
> > Haven't I given you a tag?
> Hi Any, Thank you for reviewing the patch. I appreciate it.
> I thought I would need another tag since this patch is a v2.
It depends on the nature of the changes you made. As far as I read the
code the changes you made are in addition to what I have tagged and I
see nothing that prevents you from keeping the tag.
> Sorry for this back and forth. Have a great one.
NP.
--
With Best Regards,
Andy Shevchenko
On Mon, 21 Mar 2022 18:22:10 +0200
Andy Shevchenko <[email protected]> wrote:
> On Mon, Mar 21, 2022 at 5:53 PM Tong Zhang <[email protected]> wrote:
> > On Mon, Mar 21, 2022 at 1:28 AM Andy Shevchenko
> > <[email protected]> wrote:
> > > On Sun, Mar 20, 2022 at 8:44 AM Tong Zhang <[email protected]> wrote:
>
> ...
>
> > > Haven't I given you a tag?
>
> > Hi Any, Thank you for reviewing the patch. I appreciate it.
> > I thought I would need another tag since this patch is a v2.
>
> It depends on the nature of the changes you made. As far as I read the
> code the changes you made are in addition to what I have tagged and I
> see nothing that prevents you from keeping the tag.
>
> > Sorry for this back and forth. Have a great one.
>
> NP.
>
Applied to the fixes-togreg branch of iio.git but I won't push
it out until I've rebased that on rc1 once available.
Thanks,
Jonathan