2012-10-18 18:18:57

by Daniel Vacek

[permalink] [raw]
Subject: Re: [PATCH] efi: Build EFI stub with EFI-appropriate options

On Fri, Jul 27, 2012 at 12:00 AM, Matthew Garrett <[email protected]> wrote:
> We can't assume the presence of the red zone while we're still in a boot
> services environment, so we should build with -fno-red-zone to avoid
> problems. Change the size of wchar at the same time to make string handling
> simpler.
>
> Signed-off-by: Matthew Garrett <[email protected]>
> ---
> arch/x86/boot/compressed/Makefile | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/x86/boot/compressed/Makefile b/arch/x86/boot/compressed/Makefile
> index e398bb5..8a84501 100644
> --- a/arch/x86/boot/compressed/Makefile
> +++ b/arch/x86/boot/compressed/Makefile
> @@ -28,6 +28,9 @@ VMLINUX_OBJS = $(obj)/vmlinux.lds $(obj)/head_$(BITS).o $(obj)/misc.o \
> $(obj)/string.o $(obj)/cmdline.o $(obj)/early_serial_console.o \
> $(obj)/piggy.o
>
> +$(obj)/eboot.o: KBUILD_CFLAGS += -fshort-wchar -mno-red-zone
> +$(obj)/efi_stub_$(BITS).o: KBUILD_CLFAGS += -fshort-wchar -mno-red-zone
> +
> ifeq ($(CONFIG_EFI_STUB), y)
> VMLINUX_OBJS += $(obj)/eboot.o $(obj)/efi_stub_$(BITS).o
> endif

s/CLFAGS/CFLAGS/

should go to stable too?

--nX


2012-10-18 18:28:44

by Matthew Garrett

[permalink] [raw]
Subject: Re: [PATCH] efi: Build EFI stub with EFI-appropriate options

On Thu, Oct 18, 2012 at 08:18:51PM +0200, Daniel Vacek wrote:

> s/CLFAGS/CFLAGS/
>
> should go to stable too?

Crap. Yes. Feel free to send that.

--
Matthew Garrett | [email protected]

2012-10-18 20:32:54

by Daniel Vacek

[permalink] [raw]
Subject: Re: [PATCH] efi: Build EFI stub with EFI-appropriate options

On Thu, Oct 18, 2012 at 8:28 PM, Matthew Garrett <[email protected]> wrote:
> On Thu, Oct 18, 2012 at 08:18:51PM +0200, Daniel Vacek wrote:
>
>> s/CLFAGS/CFLAGS/
>>
>> should go to stable too?
>
> Crap. Yes. Feel free to send that.

--nX


Attachments:
0001-efi-fix-typo-in-Makefile.patch (904.00 B)

2012-10-24 17:52:32

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] efi: Build EFI stub with EFI-appropriate options

On Thu, Oct 18, 2012 at 10:32:50PM +0200, Daniel Vacek wrote:
> On Thu, Oct 18, 2012 at 8:28 PM, Matthew Garrett <[email protected]> wrote:
> > On Thu, Oct 18, 2012 at 08:18:51PM +0200, Daniel Vacek wrote:
> >
> >> s/CLFAGS/CFLAGS/
> >>
> >> should go to stable too?
> >
> > Crap. Yes. Feel free to send that.

Applied, thanks.

greg k-h

2012-10-24 20:20:44

by Daniel Vacek

[permalink] [raw]
Subject: Re: [PATCH] efi: Build EFI stub with EFI-appropriate options

On Wed, Oct 24, 2012 at 7:52 PM, Greg KH <[email protected]> wrote:
> On Thu, Oct 18, 2012 at 10:32:50PM +0200, Daniel Vacek wrote:
>> On Thu, Oct 18, 2012 at 8:28 PM, Matthew Garrett <[email protected]> wrote:
>> > On Thu, Oct 18, 2012 at 08:18:51PM +0200, Daniel Vacek wrote:
>> >
>> >> s/CLFAGS/CFLAGS/
>> >>
>> >> should go to stable too?
>> >
>> > Crap. Yes. Feel free to send that.
>
> Applied, thanks.

Something went wrong. I responded to the other two emails.

--nX