2023-05-05 08:25:01

by Varadarajan Narayanan

Subject: [PATCH v10 9/9] arm64: dts: qcom: ipq9574: Enable USB

Turn on USB related nodes
Provide vdd info

Signed-off-by: Varadarajan Narayanan <[email protected]>
---
Changes in v10:
- Provide vdd info

Changes in v5:
- Move "host" mode specification to board dts
- Due to dependency with earlier patches board dts
filename changed ipq9574-al02-c7.dts -> ipq9574-rdp433.dts

Changes in v2:
- Fix node placement and coding style
- "ok" -> "okay"
---
arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts
index 1f5d14f..18d642c 100644
--- a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts
+++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts
@@ -70,6 +70,10 @@
};
};

+&dwc_0 {
+ dr_mode = "host";
+};
+
&pcie1_phy {
status = "okay";
};
@@ -122,6 +126,21 @@
clock-frequency = <32000>;
};

+&usb_0_qmpphy {
+ vdda-pll-supply = <&mp5496_l2>;
+ vdda-phy-supply = <&fixed_0p925>;
+
+ status = "okay";
+};
+
+&usb_0_qusbphy {
+ vdd-supply = <&fixed_0p925>;
+ vdda-pll-supply = <&mp5496_l2>;
+ vdda-phy-dpdm-supply = <&fixed_3p3>;
+
+ status = "okay";
+};
+
&tlmm {

pcie_1_pin: pcie-1-state {
@@ -188,6 +207,10 @@
};
};

+&usb3 {
+ status = "okay";
+};
+
&xo_board_clk {
clock-frequency = <24000000>;
};
--
2.7.4

2023-05-05 09:39:30

by Dmitry Baryshkov

Subject: Re: [PATCH v10 9/9] arm64: dts: qcom: ipq9574: Enable USB

On Fri, 5 May 2023 at 11:24, Varadarajan Narayanan
<[email protected]> wrote:
>
> Turn on USB related nodes
> Provide vdd info
>
> Signed-off-by: Varadarajan Narayanan <[email protected]>
> ---
> Changes in v10:
> - Provide vdd info
>
> Changes in v5:
> - Move "host" mode specification to board dts
> - Due to dependency with earlier patches board dts
> filename changed ipq9574-al02-c7.dts -> ipq9574-rdp433.dts
>
> Changes in v2:
> - Fix node placement and coding style
> - "ok" -> "okay"
> ---
> arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts
> index 1f5d14f..18d642c 100644
> --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts
> +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts
> @@ -70,6 +70,10 @@
> };
> };
>
> +&dwc_0 {

If the node alias was usb_0_dwc3, it would have been next to the main
usb_0 node. Could you please fix the alias.

> + dr_mode = "host";
> +};
> +
> &pcie1_phy {
> status = "okay";
> };
> @@ -122,6 +126,21 @@
> clock-frequency = <32000>;
> };
>
> +&usb_0_qmpphy {
> + vdda-pll-supply = <&mp5496_l2>;
> + vdda-phy-supply = <&fixed_0p925>;
> +
> + status = "okay";
> +};
> +
> +&usb_0_qusbphy {
> + vdd-supply = <&fixed_0p925>;
> + vdda-pll-supply = <&mp5496_l2>;
> + vdda-phy-dpdm-supply = <&fixed_3p3>;
> +
> + status = "okay";
> +};
> +
> &tlmm {

If sorted alphabetically, 'u' comes after 't', so these two chunks are
out of order and should be fixed.

>
> pcie_1_pin: pcie-1-state {
> @@ -188,6 +207,10 @@
> };
> };
>
> +&usb3 {
> + status = "okay";
> +};
> +
> &xo_board_clk {
> clock-frequency = <24000000>;
> };
> --
> 2.7.4
>


--
With best wishes
Dmitry