2024-05-14 02:59:58

by Liu Ying

Subject: [PATCH] arm: dts: imx53-qsb-hdmi: Disable panel instead of deleting node

We cannot use /delete-node/ directive to delete a node in a DT
overlay. The node won't be deleted effectively. Instead, set
the node's status property to "disabled" to achieve something
similar.

Fixes: eeb403df953f ("ARM: dts: imx53-qsb: add support for the HDMI expander")
Signed-off-by: Liu Ying <[email protected]>
---
arch/arm/boot/dts/nxp/imx/imx53-qsb-common.dtsi | 2 +-
arch/arm/boot/dts/nxp/imx/imx53-qsb-hdmi.dtso | 6 ++++--
2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx53-qsb-common.dtsi b/arch/arm/boot/dts/nxp/imx/imx53-qsb-common.dtsi
index d80440446473..05d7a462ea25 100644
--- a/arch/arm/boot/dts/nxp/imx/imx53-qsb-common.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx53-qsb-common.dtsi
@@ -85,7 +85,7 @@ led-user {
};
};

- panel {
+ panel_dpi: panel {
compatible = "sii,43wvf1g";
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_display_power>;
diff --git a/arch/arm/boot/dts/nxp/imx/imx53-qsb-hdmi.dtso b/arch/arm/boot/dts/nxp/imx/imx53-qsb-hdmi.dtso
index c84e9b052527..151e9cee3c87 100644
--- a/arch/arm/boot/dts/nxp/imx/imx53-qsb-hdmi.dtso
+++ b/arch/arm/boot/dts/nxp/imx/imx53-qsb-hdmi.dtso
@@ -10,8 +10,6 @@
/plugin/;

&{/} {
- /delete-node/ panel;
-
hdmi: connector-hdmi {
compatible = "hdmi-connector";
label = "hdmi";
@@ -82,6 +80,10 @@ sii9022_out: endpoint {
};
};

+&panel_dpi {
+ status = "disabled";
+};
+
&tve {
status = "disabled";
};
--
2.34.1

2024-06-02 10:41:21

by Dmitry Baryshkov

Subject: Re: [PATCH] arm: dts: imx53-qsb-hdmi: Disable panel instead of deleting node

On Tue, 14 May 2024 at 05:59, Liu Ying <[email protected]> wrote:
>
> We cannot use /delete-node/ directive to delete a node in a DT
> overlay. The node won't be deleted effectively. Instead, set
> the node's status property to "disabled" to achieve something
> similar.
>
> Fixes: eeb403df953f ("ARM: dts: imx53-qsb: add support for the HDMI expander")
> Signed-off-by: Liu Ying <[email protected]>
> ---
> arch/arm/boot/dts/nxp/imx/imx53-qsb-common.dtsi | 2 +-
> arch/arm/boot/dts/nxp/imx/imx53-qsb-hdmi.dtso | 6 ++++--
> 2 files changed, 5 insertions(+), 3 deletions(-)

Reviewed-by: Dmitry Baryshkov <[email protected]>

--
With best wishes
Dmitry

2024-06-15 08:08:38

by Shawn Guo

Subject: Re: [PATCH] arm: dts: imx53-qsb-hdmi: Disable panel instead of deleting node

On Tue, May 14, 2024 at 11:07:18AM +0800, Liu Ying wrote:
> We cannot use /delete-node/ directive to delete a node in a DT
> overlay. The node won't be deleted effectively. Instead, set
> the node's status property to "disabled" to achieve something
> similar.
>
> Fixes: eeb403df953f ("ARM: dts: imx53-qsb: add support for the HDMI expander")
> Signed-off-by: Liu Ying <[email protected]>

Applied, thanks!