2023-01-13 06:44:05

by Judy Hsiao

Subject: [PATCH v2] arm64: dts: qcom: sc7280: add display port audio

Add DisplayPort sound node and lpass_cpu node
in sc7280-herobrine-audio-rt5682.dtsi.

Signed-off-by: Judy Hsiao <[email protected]>

---
Changes Since v1:
-- Fix the commit message.


(no changes since v1)

.../qcom/sc7280-herobrine-audio-rt5682.dtsi | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
index af685bc35e10..69e7aa7b2f6c 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
@@ -33,9 +33,22 @@ codec {
};

dai-link@1 {
- link-name = "ALC5682";
+ link-name = "DisplayPort";
reg = <1>;

+ cpu {
+ sound-dai = <&lpass_cpu LPASS_DP_RX>;
+ };
+
+ codec {
+ sound-dai = <&mdss_dp>;
+ };
+ };
+
+ dai-link@2 {
+ link-name = "ALC5682";
+ reg = <2>;
+
cpu {
sound-dai = <&lpass_cpu MI2S_PRIMARY>;
};
@@ -92,6 +105,10 @@ dai-link@1 {
reg = <MI2S_SECONDARY>;
qcom,playback-sd-lines = <0>;
};
+
+ dai-link@5 {
+ reg = <LPASS_DP_RX>;
+ };
};

/* PINCTRL - ADDITIONS TO NODES IN PARENT DEVICE TREE FILES */
--
2.39.0.314.g84b9a713c41-goog

2023-01-13 07:05:07

by Dmitry Baryshkov

Subject: Re: [PATCH v2] arm64: dts: qcom: sc7280: add display port audio

On Fri, 13 Jan 2023 at 08:23, Judy Hsiao <[email protected]> wrote:
>
> Add DisplayPort sound node and lpass_cpu node
> in sc7280-herobrine-audio-rt5682.dtsi.

Any reason for inserting it in front of the ALC rather than putting it
at the end of dai-links?

>
> Signed-off-by: Judy Hsiao <[email protected]>


--
With best wishes
Dmitry

2023-01-13 08:37:48

by Krzysztof Kozlowski

Subject: Re: [PATCH v2] arm64: dts: qcom: sc7280: add display port audio

On 13/01/2023 07:22, Judy Hsiao wrote:
> Add DisplayPort sound node and lpass_cpu node
> in sc7280-herobrine-audio-rt5682.dtsi.

This we see from diff. You should explain stuff which is not easily
visible, e.g. why you are doing it, what do you want to achieve.

>
> Signed-off-by: Judy Hsiao <[email protected]>
>
> ---
> Changes Since v1:
> -- Fix the commit message.
>
>
> (no changes since v1)
>
> .../qcom/sc7280-herobrine-audio-rt5682.dtsi | 19 ++++++++++++++++++-
> 1 file changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
> index af685bc35e10..69e7aa7b2f6c 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
> @@ -33,9 +33,22 @@ codec {
> };
>
> dai-link@1 {
> - link-name = "ALC5682";
> + link-name = "DisplayPort";

This change is still not explained in commit msg.

Best regards,
Krzysztof