Force GCC device nodes to have the name 'clock-controller'. Several
platforms used 'gcc' here.
Signed-off-by: Dmitry Baryshkov <[email protected]>
---
Documentation/devicetree/bindings/clock/qcom,gcc-nopd.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-nopd.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-nopd.yaml
index a941e75a930a..fa9a3d3a3c67 100644
--- a/Documentation/devicetree/bindings/clock/qcom,gcc-nopd.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,gcc-nopd.yaml
@@ -14,7 +14,12 @@ description: |
Common bindings for Qualcomm global clock control module providing the
clocks and resets.
+select: false
+
properties:
+ $nodename:
+ pattern: "^clock-controller@[0-9a-f]+$"
+
'#clock-cells':
const: 1
--
2.39.2
On 28/05/2024 22:43, Dmitry Baryshkov wrote:
> Force GCC device nodes to have the name 'clock-controller'. Several
> platforms used 'gcc' here.
Well, only ones coming from Qualcomm being downstream-based:
Author: Varadarajan Narayanan <[email protected]>
Date: Thu Jun 29 11:48:33 2017 +0530
Author: Sricharan Ramabadhran <[email protected]>
Date: Sun Jan 19 18:43:20 2020 +0530
(and there was also older with node name qcom,gcc, so clearly copy-paste
from downstream sources)
yet still we do not enforce names in individual schemas. You add it now
and next month turns out there is a power-reset-clock-controller which
could use gcc.yaml, but cannot because of node name enforcement.
Best regards,
Krzysztof
On Wed, 29 May 2024 at 10:39, Krzysztof Kozlowski <[email protected]> wrote:
>
> On 28/05/2024 22:43, Dmitry Baryshkov wrote:
> > Force GCC device nodes to have the name 'clock-controller'. Several
> > platforms used 'gcc' here.
>
> Well, only ones coming from Qualcomm being downstream-based:
>
> Author: Varadarajan Narayanan <[email protected]>
> Date: Thu Jun 29 11:48:33 2017 +0530
>
> Author: Sricharan Ramabadhran <[email protected]>
> Date: Sun Jan 19 18:43:20 2020 +0530
>
> (and there was also older with node name qcom,gcc, so clearly copy-paste
> from downstream sources)
>
> yet still we do not enforce names in individual schemas. You add it now
> and next month turns out there is a power-reset-clock-controller which
> could use gcc.yaml, but cannot because of node name enforcement.
Ok, please ignore this patch, I'll drop it from the next iteration
--
With best wishes
Dmitry