2022-12-24 05:38:15

by Zhouyi Zhou

Subject: [PATCH linux-next] lib: Dhrystone: initialize ret value

Initialize ret value whenever 'if' condition is false in dhry_run_set.

Signed-off-by: Zhouyi Zhou <[email protected]>
---
Dear Developers:
When I invoke make bzImage LLVM=1, clang complains followings:
lib/dhry_run.c:61:6: error: variable 'ret' is used uninitialized whenever 'if' condition is false

Fix above complain by initialize the ret value.

Thanks
Zhouyi
--
lib/dhry_run.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/lib/dhry_run.c b/lib/dhry_run.c
index 31a1d442e4a0..be86e5126c29 100644
--- a/lib/dhry_run.c
+++ b/lib/dhry_run.c
@@ -64,6 +64,7 @@ static int dhry_run_set(const char *val, const struct kernel_param *kp)
return ret;
} else {
dhry_run = true;
+ ret = 0;
}

if (dhry_run && system_state == SYSTEM_RUNNING)
--
2.34.1

2022-12-24 06:41:44

by Nathan Chancellor

Subject: Re: [PATCH linux-next] lib: Dhrystone: initialize ret value

On Sat, Dec 24, 2022 at 01:06:40PM +0800, Zhouyi Zhou wrote:
> Initialize ret value whenever 'if' condition is false in dhry_run_set.
>
> Signed-off-by: Zhouyi Zhou <[email protected]>
> ---
> Dear Developers:
> When I invoke make bzImage LLVM=1, clang complains followings:
> lib/dhry_run.c:61:6: error: variable 'ret' is used uninitialized whenever 'if' condition is false
>
> Fix above complain by initialize the ret value.
>
> Thanks
> Zhouyi

Thank you for the patch! I think this has already been fixed:

https://lore.kernel.org/[email protected]/

-next is on a break so it won't be there for a bit:

https://lore.kernel.org/[email protected]/

Cheers,
Nathan

> --
> lib/dhry_run.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/dhry_run.c b/lib/dhry_run.c
> index 31a1d442e4a0..be86e5126c29 100644
> --- a/lib/dhry_run.c
> +++ b/lib/dhry_run.c
> @@ -64,6 +64,7 @@ static int dhry_run_set(const char *val, const struct kernel_param *kp)
> return ret;
> } else {
> dhry_run = true;
> + ret = 0;
> }
>
> if (dhry_run && system_state == SYSTEM_RUNNING)
> --
> 2.34.1
>

2022-12-24 06:46:47

by Zhouyi Zhou

Subject: Re: [PATCH linux-next] lib: Dhrystone: initialize ret value

On Sat, Dec 24, 2022 at 1:58 PM Nathan Chancellor <[email protected]> wrote:
>
> On Sat, Dec 24, 2022 at 01:06:40PM +0800, Zhouyi Zhou wrote:
> > Initialize ret value whenever 'if' condition is false in dhry_run_set.
> >
> > Signed-off-by: Zhouyi Zhou <[email protected]>
> > ---
> > Dear Developers:
> > When I invoke make bzImage LLVM=1, clang complains followings:
> > lib/dhry_run.c:61:6: error: variable 'ret' is used uninitialized whenever 'if' condition is false
> >
> > Fix above complain by initialize the ret value.
> >
> > Thanks
> > Zhouyi
>
> Thank you for the patch! I think this has already been fixed:
>
> https://lore.kernel.org/[email protected]/
Thank you for reviewing my patch ;-), I see
>
> -next is on a break so it won't be there for a bit:
>
> https://lore.kernel.org/[email protected]/
Thank you for your guidance, I think I should stop working on -next
for awhile ;-)
>
> Cheers,
> Nathan
Cheers
Zhouyi
>
> > --
> > lib/dhry_run.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/lib/dhry_run.c b/lib/dhry_run.c
> > index 31a1d442e4a0..be86e5126c29 100644
> > --- a/lib/dhry_run.c
> > +++ b/lib/dhry_run.c
> > @@ -64,6 +64,7 @@ static int dhry_run_set(const char *val, const struct kernel_param *kp)
> > return ret;
> > } else {
> > dhry_run = true;
> > + ret = 0;
> > }
> >
> > if (dhry_run && system_state == SYSTEM_RUNNING)
> > --
> > 2.34.1
> >