2021-04-29 04:29:51

by Hsin-Yi Wang

Subject: [PATCH v6 2/3] drm/mediatek: init panel orientation property

Init panel orientation property after connector is initialized. Let the
panel driver decides the orientation value later.

Signed-off-by: Hsin-Yi Wang <[email protected]>
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
index ae403c67cbd9..9da1fd649131 100644
--- a/drivers/gpu/drm/mediatek/mtk_dsi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
@@ -964,6 +964,13 @@ static int mtk_dsi_encoder_init(struct drm_device *drm, struct mtk_dsi *dsi)
ret = PTR_ERR(dsi->connector);
goto err_cleanup_encoder;
}
+
+ ret = drm_connector_init_panel_orientation_property(dsi->connector);
+ if (ret) {
+ DRM_ERROR("Unable to init panel orientation\n");
+ goto err_cleanup_encoder;
+ }
+
drm_connector_attach_encoder(dsi->connector, &dsi->encoder);

return 0;
--
2.31.1.498.g6c1eba8ee3d-goog

2021-05-11 16:24:48

by Chun-Kuang Hu

Subject: Re: [PATCH v6 2/3] drm/mediatek: init panel orientation property

Hi, Hsin-Yi:

Hsin-Yi Wang <[email protected]> 於 2021年4月29日 週四 下午12:28寫道：
>
> Init panel orientation property after connector is initialized. Let the
> panel driver decides the orientation value later.

Acked-by: Chun-Kuang Hu <[email protected]>

>
> Signed-off-by: Hsin-Yi Wang <[email protected]>
> ---
> drivers/gpu/drm/mediatek/mtk_dsi.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index ae403c67cbd9..9da1fd649131 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -964,6 +964,13 @@ static int mtk_dsi_encoder_init(struct drm_device *drm, struct mtk_dsi *dsi)
> ret = PTR_ERR(dsi->connector);
> goto err_cleanup_encoder;
> }
> +
> + ret = drm_connector_init_panel_orientation_property(dsi->connector);
> + if (ret) {
> + DRM_ERROR("Unable to init panel orientation\n");
> + goto err_cleanup_encoder;
> + }
> +
> drm_connector_attach_encoder(dsi->connector, &dsi->encoder);
>
> return 0;
> --
> 2.31.1.498.g6c1eba8ee3d-goog
>