Hi, Alexandre:
Alexandre Mergnat <[email protected]> 於 2023年3月9日 週四 下午10:23寫道：
>
> From: Fabien Parent <[email protected]>
>
> DPI for MT8365 is compatible with MT8192 but requires an additional
> clock. Modify the documentation to requires this clock only on MT8365 SoCs.
If MT8365 DPI has additional clock, why it is compatible with MT8192 DPI?
I think some part of MT8165 DPI works under the speed control by the
DPI clock and this is different with MT8192 DPI, how could these two
are compatible?
Regards,
Chun-Kuang.
>
> Signed-off-by: Fabien Parent <[email protected]>
> Signed-off-by: Alexandre Mergnat <[email protected]>
> ---
> .../bindings/display/mediatek/mediatek,dpi.yaml | 48 ++++++++++++++++++----
> 1 file changed, 39 insertions(+), 9 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> index 56511c4d4b9b..3f6cca81340c 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> @@ -17,15 +17,20 @@ description: |
>
> properties:
> compatible:
> - enum:
> - - mediatek,mt2701-dpi
> - - mediatek,mt7623-dpi
> - - mediatek,mt8173-dpi
> - - mediatek,mt8183-dpi
> - - mediatek,mt8186-dpi
> - - mediatek,mt8188-dp-intf
> - - mediatek,mt8192-dpi
> - - mediatek,mt8195-dp-intf
> + oneOf:
> + - enum:
> + - mediatek,mt2701-dpi
> + - mediatek,mt7623-dpi
> + - mediatek,mt8173-dpi
> + - mediatek,mt8183-dpi
> + - mediatek,mt8186-dpi
> + - mediatek,mt8188-dp-intf
> + - mediatek,mt8192-dpi
> + - mediatek,mt8195-dp-intf
> + - items:
> + - enum:
> + - mediatek,mt8365-dpi
> + - const: mediatek,mt8192-dpi
>
> reg:
> maxItems: 1
> @@ -34,16 +39,20 @@ properties:
> maxItems: 1
>
> clocks:
> + minItems: 3
> items:
> - description: Pixel Clock
> - description: Engine Clock
> - description: DPI PLL
> + - description: DPI Clock
>
> clock-names:
> + minItems: 3
> items:
> - const: pixel
> - const: engine
> - const: pll
> + - const: dpi
>
> pinctrl-0: true
> pinctrl-1: true
> @@ -72,6 +81,27 @@ required:
>
> additionalProperties: false
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: mediatek,mt8365-dpi
> +
> + then:
> + properties:
> + clocks:
> + maxItems: 4
> + clock-names:
> + maxItems: 4
> +
> + else:
> + properties:
> + clocks:
> + maxItems: 3
> + clock-names:
> + maxItems: 3
> +
> examples:
> - |
> #include <dt-bindings/interrupt-controller/arm-gic.h>
>
> --
> b4 0.10.1
Hi Chun-Kuang,
Le lun. 13 mars 2023 à 16:17, Chun-Kuang Hu <[email protected]> a écrit :
>
> Hi, Alexandre:
>
> Alexandre Mergnat <[email protected]> 於 2023年3月9日 週四 下午10:23寫道：
> >
> > From: Fabien Parent <[email protected]>
> >
> > DPI for MT8365 is compatible with MT8192 but requires an additional
> > clock. Modify the documentation to requires this clock only on MT8365 SoCs.
>
> If MT8365 DPI has additional clock, why it is compatible with MT8192 DPI?
> I think some part of MT8165 DPI works under the speed control by the
> DPI clock and this is different with MT8192 DPI, how could these two
> are compatible?
AFAII, The mtk_dpi driver manage the 4th clock as optional
dpi->dpi_clk = devm_clk_get_optional(dev, "dpi");
And all configuration variables for mt8192 are the same for mt8365.
These configuration clock variables (like cal_factor) aren't
correlated with the 4th clock.
The clock number doesn't impact the configuration variable because the
4th clock is simply retrieved from DTS, saved in the driver structure
and prepare/unprepare/enable/disable, like other clocks.
Regards,
Alex