2022-04-16 01:59:45

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH V2 1/3] dt-bindings: display: mediatek: Update disp_aal binding for MT8183

On Mon, 11 Apr 2022 11:58:41 +0800, Rex-BC Chen wrote:
> The driver data of MT8183 and MT8173 are different.
>
> For MT8173, the gamma module is inside disp_aal. When we need to adjust
> gamma value, we need to use "has_gamma" to control gamma function
> inside disp_aal to adjust the gamma value.
>
> For successors like MT8183, disp_gamma is separated from disp_aal. We
> just need to control disp_gamma directly and don't need to control gamma
> function inside disp_aal.
>
> With this modification, the driver doesn't require any functional changes.
> We only update the dt-binding and DTS node to make it clear.
>
> Signed-off-by: Rex-BC Chen <[email protected]>
> Reviewed-by: AngeloGioacchino Del Regno <[email protected]>
> ---
> .../devicetree/bindings/display/mediatek/mediatek,aal.yaml | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>

Acked-by: Rob Herring <[email protected]>


2022-04-18 04:03:44

by Chun-Kuang Hu

[permalink] [raw]
Subject: Re: [PATCH V2 1/3] dt-bindings: display: mediatek: Update disp_aal binding for MT8183

Rob Herring <[email protected]> 於 2022年4月14日 週四 上午7:02寫道:
>
> On Mon, 11 Apr 2022 11:58:41 +0800, Rex-BC Chen wrote:
> > The driver data of MT8183 and MT8173 are different.
> >
> > For MT8173, the gamma module is inside disp_aal. When we need to adjust
> > gamma value, we need to use "has_gamma" to control gamma function
> > inside disp_aal to adjust the gamma value.
> >
> > For successors like MT8183, disp_gamma is separated from disp_aal. We
> > just need to control disp_gamma directly and don't need to control gamma
> > function inside disp_aal.
> >
> > With this modification, the driver doesn't require any functional changes.
> > We only update the dt-binding and DTS node to make it clear.
> >
> > Signed-off-by: Rex-BC Chen <[email protected]>
> > Reviewed-by: AngeloGioacchino Del Regno <[email protected]>
> > ---
> > .../devicetree/bindings/display/mediatek/mediatek,aal.yaml | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
>
> Acked-by: Rob Herring <[email protected]>

Applied to mediatek-drm-next [1], thanks.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next

Regards,
Chun-Kuang.