The item which have the mediatek,mt8192-disp-ccorr const compatible already
exist above. Remove duplicated fallback.
Fixes: 137272ef1b0f ("dt-bindings: display: mediatek: Fix the fallback for mediatek,mt8186-disp-ccorr")
Signed-off-by: Alexandre Mergnat <[email protected]>
---
Fix MTK color correction binding
The fallback compatible has been duplicated in the 137272ef1b0f commit.
To: Chun-Kuang Hu <[email protected]>
To: Philipp Zabel <[email protected]>
To: David Airlie <[email protected]>
To: Daniel Vetter <[email protected]>
To: Rob Herring <[email protected]>
To: Krzysztof Kozlowski <[email protected]>
To: Matthias Brugger <[email protected]>
To: AngeloGioacchino Del Regno <[email protected]>
To: Allen-KH Cheng <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
Changes in v3:
- Re-order compatible.
- Link to v2: https://lore.kernel.org/r/[email protected]
Changes in v2:
- Fix commit title.
- Link to v1: https://lore.kernel.org/r/[email protected]
---
.../devicetree/bindings/display/mediatek/mediatek,ccorr.yaml | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml
index b04820c95b22..bda86e6857f5 100644
--- a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml
+++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml
@@ -27,13 +27,10 @@ properties:
- const: mediatek,mt8192-disp-ccorr
- items:
- enum:
+ - mediatek,mt8186-disp-ccorr
- mediatek,mt8188-disp-ccorr
- mediatek,mt8195-disp-ccorr
- const: mediatek,mt8192-disp-ccorr
- - items:
- - enum:
- - mediatek,mt8186-disp-ccorr
- - const: mediatek,mt8192-disp-ccorr
reg:
maxItems: 1
---
base-commit: add072536971d7ce891fde3cdbf68c55e7cfa95a
change-id: 20230306-ccorr-binding-fix-718c6d725088
Best regards,
--
Alexandre Mergnat <[email protected]>
On 06/03/2023 17:20, Alexandre Mergnat wrote:
> The item which have the mediatek,mt8192-disp-ccorr const compatible already
> exist above. Remove duplicated fallback.
Your commit msg is really misleading - I was looking for duplicated
compatible, but could not find it. You just have there unnecessary one
more list in oneOf, so this could be written simpler, but no compatibles
are duplicated...
>
> Fixes: 137272ef1b0f ("dt-bindings: display: mediatek: Fix the fallback for mediatek,mt8186-disp-ccorr")
Style issue, not a fix, because nothing is duplicated.
> Signed-off-by: Alexandre Mergnat <[email protected]>
> ---
> Fix MTK color correction binding
>
> The fallback compatible has been duplicated in the 137272ef1b0f commit.
Acked-by: Krzysztof Kozlowski <[email protected]>
Best regards,
Krzysztof
Hi, Alexandre:
Alexandre Mergnat <[email protected]> 於 2023年3月7日 週二 上午12:20寫道：
>
> The item which have the mediatek,mt8192-disp-ccorr const compatible already
> exist above. Remove duplicated fallback.
Applied to mediatek-drm-next [1], thanks.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next
Regards,
Chun-Kuang.
>
> Fixes: 137272ef1b0f ("dt-bindings: display: mediatek: Fix the fallback for mediatek,mt8186-disp-ccorr")
> Signed-off-by: Alexandre Mergnat <[email protected]>
> ---
> Fix MTK color correction binding
>
> The fallback compatible has been duplicated in the 137272ef1b0f commit.
>
> To: Chun-Kuang Hu <[email protected]>
> To: Philipp Zabel <[email protected]>
> To: David Airlie <[email protected]>
> To: Daniel Vetter <[email protected]>
> To: Rob Herring <[email protected]>
> To: Krzysztof Kozlowski <[email protected]>
> To: Matthias Brugger <[email protected]>
> To: AngeloGioacchino Del Regno <[email protected]>
> To: Allen-KH Cheng <[email protected]>
> Cc: Rob Herring <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> ---
> Changes in v3:
> - Re-order compatible.
> - Link to v2: https://lore.kernel.org/r/[email protected]
>
> Changes in v2:
> - Fix commit title.
> - Link to v1: https://lore.kernel.org/r/[email protected]
> ---
> .../devicetree/bindings/display/mediatek/mediatek,ccorr.yaml | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml
> index b04820c95b22..bda86e6857f5 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml
> @@ -27,13 +27,10 @@ properties:
> - const: mediatek,mt8192-disp-ccorr
> - items:
> - enum:
> + - mediatek,mt8186-disp-ccorr
> - mediatek,mt8188-disp-ccorr
> - mediatek,mt8195-disp-ccorr
> - const: mediatek,mt8192-disp-ccorr
> - - items:
> - - enum:
> - - mediatek,mt8186-disp-ccorr
> - - const: mediatek,mt8192-disp-ccorr
>
> reg:
> maxItems: 1
>
> ---
> base-commit: add072536971d7ce891fde3cdbf68c55e7cfa95a
> change-id: 20230306-ccorr-binding-fix-718c6d725088
>
> Best regards,
> --
> Alexandre Mergnat <[email protected]>
Hi, Alexandre:
Chun-Kuang Hu <[email protected]> 於 2023年3月13日 週一 下午10:36寫道：
>
> Hi, Alexandre:
>
> Alexandre Mergnat <[email protected]> 於 2023年3月7日 週二 上午12:20寫道：
> >
> > The item which have the mediatek,mt8192-disp-ccorr const compatible already
> > exist above. Remove duplicated fallback.
>
> Applied to mediatek-drm-next [1], thanks.
It seems that Krzysztof has some comment, so I remove this patch from
mediatek-drm-next [1].
Regards,
Chun-Kuang.
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next
>
> Regards,
> Chun-Kuang.
>
> >
> > Fixes: 137272ef1b0f ("dt-bindings: display: mediatek: Fix the fallback for mediatek,mt8186-disp-ccorr")
> > Signed-off-by: Alexandre Mergnat <[email protected]>
> > ---
> > Fix MTK color correction binding
> >
> > The fallback compatible has been duplicated in the 137272ef1b0f commit.
> >
> > To: Chun-Kuang Hu <[email protected]>
> > To: Philipp Zabel <[email protected]>
> > To: David Airlie <[email protected]>
> > To: Daniel Vetter <[email protected]>
> > To: Rob Herring <[email protected]>
> > To: Krzysztof Kozlowski <[email protected]>
> > To: Matthias Brugger <[email protected]>
> > To: AngeloGioacchino Del Regno <[email protected]>
> > To: Allen-KH Cheng <[email protected]>
> > Cc: Rob Herring <[email protected]>
> > Cc: [email protected]
> > Cc: [email protected]
> > Cc: [email protected]
> > Cc: [email protected]
> > Cc: [email protected]
> > ---
> > Changes in v3:
> > - Re-order compatible.
> > - Link to v2: https://lore.kernel.org/r/[email protected]
> >
> > Changes in v2:
> > - Fix commit title.
> > - Link to v1: https://lore.kernel.org/r/[email protected]
> > ---
> > .../devicetree/bindings/display/mediatek/mediatek,ccorr.yaml | 5 +----
> > 1 file changed, 1 insertion(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml
> > index b04820c95b22..bda86e6857f5 100644
> > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml
> > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml
> > @@ -27,13 +27,10 @@ properties:
> > - const: mediatek,mt8192-disp-ccorr
> > - items:
> > - enum:
> > + - mediatek,mt8186-disp-ccorr
> > - mediatek,mt8188-disp-ccorr
> > - mediatek,mt8195-disp-ccorr
> > - const: mediatek,mt8192-disp-ccorr
> > - - items:
> > - - enum:
> > - - mediatek,mt8186-disp-ccorr
> > - - const: mediatek,mt8192-disp-ccorr
> >
> > reg:
> > maxItems: 1
> >
> > ---
> > base-commit: add072536971d7ce891fde3cdbf68c55e7cfa95a
> > change-id: 20230306-ccorr-binding-fix-718c6d725088
> >
> > Best regards,
> > --
> > Alexandre Mergnat <[email protected]>