2021-06-22 13:11:27

by Dan Carpenter

Subject: [PATCH] mailbox: mtk-cmdq: Fix uninitialized variable in cmdq_mbox_flush()

The "cb" pointer needs to be initialized before can assign
"data.data = cb->data;".

Fixes: 4a3cb0303984 ("mailbox: mtk-cmdq: Use mailbox rx_callback")
Signed-off-by: Dan Carpenter <[email protected]>
---
drivers/mailbox/mtk-cmdq-mailbox.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
index 301e65b9527a..67a42b514429 100644
--- a/drivers/mailbox/mtk-cmdq-mailbox.c
+++ b/drivers/mailbox/mtk-cmdq-mailbox.c
@@ -455,10 +455,10 @@ static int cmdq_mbox_flush(struct mbox_chan *chan, unsigned long timeout)

list_for_each_entry_safe(task, tmp, &thread->task_busy_list,
list_entry) {
+ cb = &task->pkt->async_cb;
data.sta = -ECONNABORTED;
data.data = cb->data;
data.pkt = task->pkt;
- cb = &task->pkt->async_cb;
if (cb->cb)
cb->cb(data);

--
2.30.2

2021-06-25 09:09:53

by Chun-Kuang Hu

Subject: Re: [PATCH] mailbox: mtk-cmdq: Fix uninitialized variable in cmdq_mbox_flush()

Hi, Dan:

Dan Carpenter <[email protected]> 於 2021年6月22日 週二 下午9:09寫道：
>
> The "cb" pointer needs to be initialized before can assign
> "data.data = cb->data;".

Reviewed-by: Chun-Kuang Hu <[email protected]>

>
> Fixes: 4a3cb0303984 ("mailbox: mtk-cmdq: Use mailbox rx_callback")
> Signed-off-by: Dan Carpenter <[email protected]>
> ---
> drivers/mailbox/mtk-cmdq-mailbox.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
> index 301e65b9527a..67a42b514429 100644
> --- a/drivers/mailbox/mtk-cmdq-mailbox.c
> +++ b/drivers/mailbox/mtk-cmdq-mailbox.c
> @@ -455,10 +455,10 @@ static int cmdq_mbox_flush(struct mbox_chan *chan, unsigned long timeout)
>
> list_for_each_entry_safe(task, tmp, &thread->task_busy_list,
> list_entry) {
> + cb = &task->pkt->async_cb;
> data.sta = -ECONNABORTED;
> data.data = cb->data;
> data.pkt = task->pkt;
> - cb = &task->pkt->async_cb;
> if (cb->cb)
> cb->cb(data);
>
> --
> 2.30.2
>