2018-10-27 19:12:09

by Julia Lawall

[permalink] [raw]
Subject: [PATCH] PCI: histb: constify dw_pcie_host_ops structure

The dw_pcie_host_ops structure is only stored in the ops field
of a pcie_port structure, and this field is const, so make the
dw_pcie_host_ops structure const as well.

Done with the help of Coccinelle.

Signed-off-by: Julia Lawall <[email protected]>

---
drivers/pci/controller/dwc/pcie-histb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff -u -p a/drivers/pci/controller/dwc/pcie-histb.c b/drivers/pci/controller/dwc/pcie-histb.c
--- a/drivers/pci/controller/dwc/pcie-histb.c
+++ b/drivers/pci/controller/dwc/pcie-histb.c
@@ -202,7 +202,7 @@ static int histb_pcie_host_init(struct p
return 0;
}

-static struct dw_pcie_host_ops histb_pcie_host_ops = {
+static const struct dw_pcie_host_ops histb_pcie_host_ops = {
.rd_own_conf = histb_pcie_rd_own_conf,
.wr_own_conf = histb_pcie_wr_own_conf,
.host_init = histb_pcie_host_init,



2018-10-29 02:01:00

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH] PCI: histb: constify dw_pcie_host_ops structure

On Sun, Oct 28, 2018 at 3:06 AM Julia Lawall <[email protected]> wrote:
>
> The dw_pcie_host_ops structure is only stored in the ops field
> of a pcie_port structure, and this field is const, so make the
> dw_pcie_host_ops structure const as well.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <[email protected]>

Acked-by: Shawn Guo <[email protected]>

2018-11-20 12:58:54

by Lorenzo Pieralisi

[permalink] [raw]
Subject: Re: [PATCH] PCI: histb: constify dw_pcie_host_ops structure

On Sat, Oct 27, 2018 at 08:31:19PM +0200, Julia Lawall wrote:
> The dw_pcie_host_ops structure is only stored in the ops field
> of a pcie_port structure, and this field is const, so make the
> dw_pcie_host_ops structure const as well.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <[email protected]>
>
> ---
> drivers/pci/controller/dwc/pcie-histb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to pci/dwc for v4.21, thanks.

Lorenzo

> diff -u -p a/drivers/pci/controller/dwc/pcie-histb.c b/drivers/pci/controller/dwc/pcie-histb.c
> --- a/drivers/pci/controller/dwc/pcie-histb.c
> +++ b/drivers/pci/controller/dwc/pcie-histb.c
> @@ -202,7 +202,7 @@ static int histb_pcie_host_init(struct p
> return 0;
> }
>
> -static struct dw_pcie_host_ops histb_pcie_host_ops = {
> +static const struct dw_pcie_host_ops histb_pcie_host_ops = {
> .rd_own_conf = histb_pcie_rd_own_conf,
> .wr_own_conf = histb_pcie_wr_own_conf,
> .host_init = histb_pcie_host_init,
>