2021-05-07 06:32:40

by Chunfeng Yun

Subject: [PATCH v3 4/4] usb: xhci-mtk: use first-fit for LS/FS

Use first-fit instead of best-fit for LS/FS devices under TT,
we found that best-fit will consume more bandwidth for some
cases.

Signed-off-by: Chunfeng Yun <[email protected]>
---
v3: no changes
---
drivers/usb/host/xhci-mtk-sch.c | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/drivers/usb/host/xhci-mtk-sch.c b/drivers/usb/host/xhci-mtk-sch.c
index 9fb75085e40f..c07411d9b16f 100644
--- a/drivers/usb/host/xhci-mtk-sch.c
+++ b/drivers/usb/host/xhci-mtk-sch.c
@@ -634,6 +634,11 @@ static int check_sch_bw(struct mu3h_sch_bw_info *sch_bw,
min_bw = worst_bw;
min_index = offset;
}
+
+ /* use first-fit for LS/FS */
+ if (sch_ep->sch_tt && min_index >= 0)
+ break;
+
if (min_bw == 0)
break;
}
--
2.18.0

2021-06-10 03:44:12

by Ikjoon Jang

Subject: Re: [PATCH v3 4/4] usb: xhci-mtk: use first-fit for LS/FS

On Fri, May 7, 2021 at 10:11 AM Chunfeng Yun <[email protected]> wrote:
>
> Use first-fit instead of best-fit for LS/FS devices under TT,
> we found that best-fit will consume more bandwidth for some
> cases.
>
> Signed-off-by: Chunfeng Yun <[email protected]>

Reviewed-and-Tested-by: Ikjoon Jang <[email protected]>

> ---
> v3: no changes
> ---
> drivers/usb/host/xhci-mtk-sch.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/usb/host/xhci-mtk-sch.c b/drivers/usb/host/xhci-mtk-sch.c
> index 9fb75085e40f..c07411d9b16f 100644
> --- a/drivers/usb/host/xhci-mtk-sch.c
> +++ b/drivers/usb/host/xhci-mtk-sch.c
> @@ -634,6 +634,11 @@ static int check_sch_bw(struct mu3h_sch_bw_info *sch_bw,
> min_bw = worst_bw;
> min_index = offset;
> }
> +
> + /* use first-fit for LS/FS */
> + if (sch_ep->sch_tt && min_index >= 0)
> + break;
> +
> if (min_bw == 0)
> break;
> }
> --
> 2.18.0
>