2021-05-07 06:32:40

by Chunfeng Yun

Subject: [PATCH v3 2/4] usb: xhci-mtk: remove unnecessary setting of has_ippc

Due to @has_ippc's default value is 0, no need set it again if fail
to get ippc base address

Signed-off-by: Chunfeng Yun <[email protected]>
---
v3: new patch suggested by Greg
fix typo suggested by Sergei
---
drivers/usb/host/xhci-mtk.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c
index b2058b3bc834..2548976bcf05 100644
--- a/drivers/usb/host/xhci-mtk.c
+++ b/drivers/usb/host/xhci-mtk.c
@@ -495,8 +495,6 @@ static int xhci_mtk_probe(struct platform_device *pdev)
goto put_usb2_hcd;
}
mtk->has_ippc = true;
- } else {
- mtk->has_ippc = false;
}

device_init_wakeup(dev, true);
--
2.18.0

2021-06-10 03:37:14

by Ikjoon Jang

Subject: Re: [PATCH v3 2/4] usb: xhci-mtk: remove unnecessary setting of has_ippc

On Fri, May 7, 2021 at 10:11 AM Chunfeng Yun <[email protected]> wrote:
>
> Due to @has_ippc's default value is 0, no need set it again if fail
> to get ippc base address
>
> Signed-off-by: Chunfeng Yun <[email protected]>

Reviewed-and-Tested-by: Ikjoon Jang <[email protected]>

> ---
> v3: new patch suggested by Greg
> fix typo suggested by Sergei
> ---
> drivers/usb/host/xhci-mtk.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c
> index b2058b3bc834..2548976bcf05 100644
> --- a/drivers/usb/host/xhci-mtk.c
> +++ b/drivers/usb/host/xhci-mtk.c
> @@ -495,8 +495,6 @@ static int xhci_mtk_probe(struct platform_device *pdev)
> goto put_usb2_hcd;
> }
> mtk->has_ippc = true;
> - } else {
> - mtk->has_ippc = false;
> }
>
> device_init_wakeup(dev, true);
> --
> 2.18.0
>