This patchset enables hard wired hub device to use different bInterval
from its descriptor when the hub has a combined device node.
When we know reducing autosuspend delay for built-in HIDs is better for
power saving, we can reduce it to the optimal value. But if a parent hub
has a long bInterval, mouse lags a lot from more frequent autosuspend.
So this enables overriding bInterval for a hard wired hub device only
when we know that reduces the power consumption.
Changes in v4
- use of_property_read_u32() instead of of_property_read_u8()
Ikjoon Jang (2):
dt-bindings: usb: add "hub,interval" property
usb: overridable hub bInterval by device node
Documentation/devicetree/bindings/usb/usb-device.txt | 4 ++++
drivers/usb/core/config.c | 9 +++++++++
2 files changed, 13 insertions(+)
--
2.24.0.393.g34dc348eaf-goog
On Tue, Dec 03, 2019 at 06:15:21PM +0800, Ikjoon Jang wrote:
> This patchset enables hard wired hub device to use different bInterval
> from its descriptor when the hub has a combined device node.
>
> When we know reducing autosuspend delay for built-in HIDs is better for
> power saving, we can reduce it to the optimal value. But if a parent hub
> has a long bInterval, mouse lags a lot from more frequent autosuspend.
> So this enables overriding bInterval for a hard wired hub device only
> when we know that reduces the power consumption.
>
> Changes in v4
> - use of_property_read_u32() instead of of_property_read_u8()
What changed in the previous versions?
Johan
On Wed, Dec 4, 2019 at 12:40 AM Johan Hovold <[email protected]> wrote:
>
> On Tue, Dec 03, 2019 at 06:15:21PM +0800, Ikjoon Jang wrote:
> > This patchset enables hard wired hub device to use different bInterval
> > from its descriptor when the hub has a combined device node.
> >
> > When we know reducing autosuspend delay for built-in HIDs is better for
> > power saving, we can reduce it to the optimal value. But if a parent hub
> > has a long bInterval, mouse lags a lot from more frequent autosuspend.
> > So this enables overriding bInterval for a hard wired hub device only
> > when we know that reduces the power consumption.
> >
> > Changes in v4
> > - use of_property_read_u32() instead of of_property_read_u8()
>
> What changed in the previous versions?
changes in the previous versions:
v4: use of_property_read_u32() instead of of_property_read_u8()
v3: errata fixed "hub, interval" --> "hub,interval"
v2: do not use unlikely() macro, commit message
>
> Johan