2019-11-07 04:17:56

by Ikjoon Jang

[permalink] [raw]
Subject: Re: [PATCH] ath10k: disable cpuidle during downloading firmware.

On Thu, Nov 7, 2019 at 2:23 AM Kalle Valo <[email protected]> wrote:
>
> Ikjoon Jang <[email protected]> writes:
>
> > Downloading ath10k firmware needs a large number of IOs and
> > cpuidle's miss predictions make it worse. In the worst case,
> > resume time can be three times longer than the average on sdio.
> >
> > This patch disables cpuidle during firmware downloading by
> > applying PM_QOS_CPU_DMA_LATENCY in ath10k_download_fw().
> >
> > Signed-off-by: Ikjoon Jang <[email protected]>
>
> On what hardware and firmware versions did you test this? I'll add that
> to the commit log.
>
> https://wireless.wiki.kernel.org/en/users/drivers/ath10k/submittingpatches#guidelines

Thank you for sharing it.
It's QCA6174 hw3.2 SDIO WLAN.RMH.4.4.1-00029
on ARMv8 multi cluster platform.

>
> --
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


2019-11-08 08:35:22

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] ath10k: disable cpuidle during downloading firmware.

Ikjoon Jang <[email protected]> writes:

> On Thu, Nov 7, 2019 at 2:23 AM Kalle Valo <[email protected]> wrote:
>>
>> Ikjoon Jang <[email protected]> writes:
>>
>> > Downloading ath10k firmware needs a large number of IOs and
>> > cpuidle's miss predictions make it worse. In the worst case,
>> > resume time can be three times longer than the average on sdio.
>> >
>> > This patch disables cpuidle during firmware downloading by
>> > applying PM_QOS_CPU_DMA_LATENCY in ath10k_download_fw().
>> >
>> > Signed-off-by: Ikjoon Jang <[email protected]>
>>
>> On what hardware and firmware versions did you test this? I'll add that
>> to the commit log.
>>
>> https://wireless.wiki.kernel.org/en/users/drivers/ath10k/submittingpatches#guidelines
>
> Thank you for sharing it.
> It's QCA6174 hw3.2 SDIO WLAN.RMH.4.4.1-00029
> on ARMv8 multi cluster platform.

Thanks, I added that to the commit log.

--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches