2023-05-29 12:03:42

by Franziska Näpelt

Subject: [PATCH] mips: Fix spacing issue

This removes the following checkpatch issue:
- ERROR: need consistent spacing around '-' (ctx:WxV)

Signed-off-by: Franziska Naepelt <[email protected]>
---
arch/mips/sibyte/swarm/platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/sibyte/swarm/platform.c b/arch/mips/sibyte/swarm/platform.c
index 484969db7713..06bf7105e7b1 100644
--- a/arch/mips/sibyte/swarm/platform.c
+++ b/arch/mips/sibyte/swarm/platform.c
@@ -90,7 +90,7 @@ device_initcall(swarm_pata_init);
.name = "SB1250 MAC " __stringify(num), \
.flags = IORESOURCE_MEM, \
.start = A_MAC_CHANNEL_BASE(num), \
- .end = A_MAC_CHANNEL_BASE(num + 1) -1, \
+ .end = A_MAC_CHANNEL_BASE(num + 1) - 1, \
};\
static struct platform_device sb1250_dev##num = { \
.name = "sb1250-mac", \

base-commit: 7877cb91f1081754a1487c144d85dc0d2e2e7fc4
--
2.39.2 (Apple Git-143)

2023-05-29 14:11:35

by Ladislav Michl

Subject: Re: [PATCH] mips: Fix spacing issue

Hi,

coould we just fix all whitespaces while there?

diff --git a/arch/mips/sibyte/swarm/platform.c b/arch/mips/sibyte/swarm/platform.c
index 484969db7713..339d77a0a08f 100644
--- a/arch/mips/sibyte/swarm/platform.c
+++ b/arch/mips/sibyte/swarm/platform.c
@@ -88,15 +88,15 @@ device_initcall(swarm_pata_init);
#define sb1250_dev_struct(num) \
static struct resource sb1250_res##num = { \
.name = "SB1250 MAC " __stringify(num), \
- .flags = IORESOURCE_MEM, \
- .start = A_MAC_CHANNEL_BASE(num), \
- .end = A_MAC_CHANNEL_BASE(num + 1) -1, \
+ .flags = IORESOURCE_MEM, \
+ .start = A_MAC_CHANNEL_BASE(num), \
+ .end = A_MAC_CHANNEL_BASE(num + 1) - 1, \
};\
static struct platform_device sb1250_dev##num = { \
- .name = "sb1250-mac", \
- .id = num, \
- .resource = &sb1250_res##num, \
- .num_resources = 1, \
+ .name = "sb1250-mac", \
+ .id = num, \
+ .resource = &sb1250_res##num, \
+ .num_resources = 1, \
}

sb1250_dev_struct(0);

On Mon, May 29, 2023 at 01:34:21PM +0200, Franziska Naepelt wrote:
> This removes the following checkpatch issue:
> - ERROR: need consistent spacing around '-' (ctx:WxV)
>
> Signed-off-by: Franziska Naepelt <[email protected]>
> ---
> arch/mips/sibyte/swarm/platform.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/sibyte/swarm/platform.c b/arch/mips/sibyte/swarm/platform.c
> index 484969db7713..06bf7105e7b1 100644
> --- a/arch/mips/sibyte/swarm/platform.c
> +++ b/arch/mips/sibyte/swarm/platform.c
> @@ -90,7 +90,7 @@ device_initcall(swarm_pata_init);
> .name = "SB1250 MAC " __stringify(num), \
> .flags = IORESOURCE_MEM, \
> .start = A_MAC_CHANNEL_BASE(num), \
> - .end = A_MAC_CHANNEL_BASE(num + 1) -1, \
> + .end = A_MAC_CHANNEL_BASE(num + 1) - 1, \
> };\
> static struct platform_device sb1250_dev##num = { \
> .name = "sb1250-mac", \
>
> base-commit: 7877cb91f1081754a1487c144d85dc0d2e2e7fc4
> --
> 2.39.2 (Apple Git-143)

2023-05-30 07:21:40

by Franziska Näpelt

Subject: Re: [PATCH] mips: Fix spacing issue

Am Mo., 29. Mai 2023 um 15:51 Uhr schrieb Ladislav Michl <[email protected]>:
>
> Hi,
>
> coould we just fix all whitespaces while there?
>
> diff --git a/arch/mips/sibyte/swarm/platform.c b/arch/mips/sibyte/swarm/platform.c
> index 484969db7713..339d77a0a08f 100644
> --- a/arch/mips/sibyte/swarm/platform.c
> +++ b/arch/mips/sibyte/swarm/platform.c
> @@ -88,15 +88,15 @@ device_initcall(swarm_pata_init);
> #define sb1250_dev_struct(num) \
> static struct resource sb1250_res##num = { \
> .name = "SB1250 MAC " __stringify(num), \
> - .flags = IORESOURCE_MEM, \
> - .start = A_MAC_CHANNEL_BASE(num), \
> - .end = A_MAC_CHANNEL_BASE(num + 1) -1, \
> + .flags = IORESOURCE_MEM, \
> + .start = A_MAC_CHANNEL_BASE(num), \
> + .end = A_MAC_CHANNEL_BASE(num + 1) - 1, \
> };\
> static struct platform_device sb1250_dev##num = { \
> - .name = "sb1250-mac", \
> - .id = num, \
> - .resource = &sb1250_res##num, \
> - .num_resources = 1, \
> + .name = "sb1250-mac", \
> + .id = num, \
> + .resource = &sb1250_res##num, \
> + .num_resources = 1, \
> }
>
> sb1250_dev_struct(0);
>
> On Mon, May 29, 2023 at 01:34:21PM +0200, Franziska Naepelt wrote:
> > This removes the following checkpatch issue:
> > - ERROR: need consistent spacing around '-' (ctx:WxV)
> >
> > Signed-off-by: Franziska Naepelt <[email protected]>
> > ---
> > arch/mips/sibyte/swarm/platform.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/mips/sibyte/swarm/platform.c b/arch/mips/sibyte/swarm/platform.c
> > index 484969db7713..06bf7105e7b1 100644
> > --- a/arch/mips/sibyte/swarm/platform.c
> > +++ b/arch/mips/sibyte/swarm/platform.c
> > @@ -90,7 +90,7 @@ device_initcall(swarm_pata_init);
> > .name = "SB1250 MAC " __stringify(num), \
> > .flags = IORESOURCE_MEM, \
> > .start = A_MAC_CHANNEL_BASE(num), \
> > - .end = A_MAC_CHANNEL_BASE(num + 1) -1, \
> > + .end = A_MAC_CHANNEL_BASE(num + 1) - 1, \
> > };\
> > static struct platform_device sb1250_dev##num = { \
> > .name = "sb1250-mac", \
> >
> > base-commit: 7877cb91f1081754a1487c144d85dc0d2e2e7fc4
> > --
> > 2.39.2 (Apple Git-143)

Hi Ladislav,

done in v2, thanks for your help.

Franziska