2018-09-26 22:51:40

by Valdis Klētnieks

Subject: [PATCH] crypto/morus(640,1280) - make crypto_...-algs static

sparse complains thusly:

CHECK arch/x86/crypto/morus640-sse2-glue.c
arch/x86/crypto/morus640-sse2-glue.c:38:1: warning: symbol 'crypto_morus640_sse2_algs' was not declared. Should it be static?
CHECK arch/x86/crypto/morus1280-sse2-glue.c
arch/x86/crypto/morus1280-sse2-glue.c:38:1: warning: symbol 'crypto_morus1280_sse2_algs' was not declared. Should it be static?
CHECK arch/x86/crypto/morus1280-avx2-glue.c
arch/x86/crypto/morus1280-avx2-glue.c:38:1: warning: symbol 'crypto_morus1280_avx2_algs' was not declared. Should it be static?

and sparse is correct - these don't need to be global and polluting the namespace.

Signed-off-by: Valdis Kletnieks <[email protected]>
---
diff --git a/include/crypto/morus1280_glue.h b/include/crypto/morus1280_glue.h
index b26dd70efd9a..ba782e10065e 100644
--- a/include/crypto/morus1280_glue.h
+++ b/include/crypto/morus1280_glue.h
@@ -82,7 +82,7 @@ void cryptd_morus1280_glue_exit_tfm(struct crypto_aead *aead);
{ \
} \
\
- struct aead_alg crypto_morus1280_##id##_algs[] = {\
+ static struct aead_alg crypto_morus1280_##id##_algs[] = {\
{ \
.setkey = crypto_morus1280_glue_setkey, \
.setauthsize = crypto_morus1280_glue_setauthsize, \
diff --git a/include/crypto/morus640_glue.h b/include/crypto/morus640_glue.h
index 90c8db07e740..27fa790a2362 100644
--- a/include/crypto/morus640_glue.h
+++ b/include/crypto/morus640_glue.h
@@ -82,7 +82,7 @@ void cryptd_morus640_glue_exit_tfm(struct crypto_aead *aead);
{ \
} \
\
- struct aead_alg crypto_morus640_##id##_algs[] = {\
+ static struct aead_alg crypto_morus640_##id##_algs[] = {\
{ \
.setkey = crypto_morus640_glue_setkey, \
.setauthsize = crypto_morus640_glue_setauthsize, \

2018-09-27 19:30:55

by Ondrej Mosnáček

Subject: Re: [PATCH] crypto/morus(640,1280) - make crypto_...-algs static

št 27. 9. 2018 o 0:50 <[email protected]> napísal(a):
> sparse complains thusly:
>
> CHECK arch/x86/crypto/morus640-sse2-glue.c
> arch/x86/crypto/morus640-sse2-glue.c:38:1: warning: symbol 'crypto_morus640_sse2_algs' was not declared. Should it be static?
> CHECK arch/x86/crypto/morus1280-sse2-glue.c
> arch/x86/crypto/morus1280-sse2-glue.c:38:1: warning: symbol 'crypto_morus1280_sse2_algs' was not declared. Should it be static?
> CHECK arch/x86/crypto/morus1280-avx2-glue.c
> arch/x86/crypto/morus1280-avx2-glue.c:38:1: warning: symbol 'crypto_morus1280_avx2_algs' was not declared. Should it be static?
>
> and sparse is correct - these don't need to be global and polluting the namespace.
>
> Signed-off-by: Valdis Kletnieks <[email protected]>

Indeed, this should be fixed, thanks!

Acked-by: Ondrej Mosnacek <[email protected]>

> ---
> diff --git a/include/crypto/morus1280_glue.h b/include/crypto/morus1280_glue.h
> index b26dd70efd9a..ba782e10065e 100644
> --- a/include/crypto/morus1280_glue.h
> +++ b/include/crypto/morus1280_glue.h
> @@ -82,7 +82,7 @@ void cryptd_morus1280_glue_exit_tfm(struct crypto_aead *aead);
> { \
> } \
> \
> - struct aead_alg crypto_morus1280_##id##_algs[] = {\
> + static struct aead_alg crypto_morus1280_##id##_algs[] = {\
> { \
> .setkey = crypto_morus1280_glue_setkey, \
> .setauthsize = crypto_morus1280_glue_setauthsize, \
> diff --git a/include/crypto/morus640_glue.h b/include/crypto/morus640_glue.h
> index 90c8db07e740..27fa790a2362 100644
> --- a/include/crypto/morus640_glue.h
> +++ b/include/crypto/morus640_glue.h
> @@ -82,7 +82,7 @@ void cryptd_morus640_glue_exit_tfm(struct crypto_aead *aead);
> { \
> } \
> \
> - struct aead_alg crypto_morus640_##id##_algs[] = {\
> + static struct aead_alg crypto_morus640_##id##_algs[] = {\
> { \
> .setkey = crypto_morus640_glue_setkey, \
> .setauthsize = crypto_morus640_glue_setauthsize, \
>

2018-10-05 02:31:49

by Herbert Xu

Subject: Re: [PATCH] crypto/morus(640,1280) - make crypto_...-algs static

On Wed, Sep 26, 2018 at 06:49:38PM -0400, [email protected] wrote:
> sparse complains thusly:
>
> CHECK arch/x86/crypto/morus640-sse2-glue.c
> arch/x86/crypto/morus640-sse2-glue.c:38:1: warning: symbol 'crypto_morus640_sse2_algs' was not declared. Should it be static?
> CHECK arch/x86/crypto/morus1280-sse2-glue.c
> arch/x86/crypto/morus1280-sse2-glue.c:38:1: warning: symbol 'crypto_morus1280_sse2_algs' was not declared. Should it be static?
> CHECK arch/x86/crypto/morus1280-avx2-glue.c
> arch/x86/crypto/morus1280-avx2-glue.c:38:1: warning: symbol 'crypto_morus1280_avx2_algs' was not declared. Should it be static?
>
> and sparse is correct - these don't need to be global and polluting the namespace.
>
> Signed-off-by: Valdis Kletnieks <[email protected]>

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt