2015-02-10 08:53:52

by Alexandre Courbot

[permalink] [raw]
Subject: Re: [PATCH] mmc: sdhci: Set SDHCI_POWER_ON with external vmmc

On Wed, Jan 14, 2015 at 5:53 PM, Ulf Hansson <[email protected]> wrote:
> + linux-mmc
>
> On 14 January 2015 at 07:24, Tim Kryger <[email protected]> wrote:
>> Host controllers lacking the required internal vmmc regulator may still
>> follow the spec with regard to the LSB of SDHCI_POWER_CONTROL. Set the
>> SDHCI_POWER_ON bit when vmmc is enabled to encourage the controller to
>> to drive CMD, DAT, SDCLK.
>>
>> This fixes a regression observed on some Qualcomm and Nvidia boards
>> caused by 5222161 mmc: sdhci: Improve external VDD regulator support.
>>
>> Signed-off-by: Tim Kryger <[email protected]>
>> Tested-by: Bjorn Andersson <[email protected]>
>
> Thanks! Applied for fixes.
>
> I noticed this wasn't posted to linux-mmc. I am anyway picking it up
> as this change has already been discussed and tested, see:
> https://lkml.org/lkml/2014/11/3/1029

The party is probably over for this patch, but FWIW:

Tested-by: Alexandre Courbot <[email protected]>