ret is assigned value from of_property_read_string_index but is
overwritten before being used so remove it.
Also fix coverity CID 1309759
Signed-off-by: Laurent Navet <[email protected]>
---
drivers/gpio/gpiolib-of.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
index a6c67c6..346da01 100644
--- a/drivers/gpio/gpiolib-of.c
+++ b/drivers/gpio/gpiolib-of.c
@@ -365,7 +365,7 @@ static void of_gpiochip_add_pin_range(struct gpio_chip *chip)
if (pinspec.args[2]) {
if (group_names) {
- ret = of_property_read_string_index(np,
+ of_property_read_string_index(np,
group_names_propname,
index, &name);
if (strlen(name)) {
--
2.1.4
On Wed, Jul 8, 2015 at 5:22 AM, Laurent Navet <[email protected]> wrote:
> ret is assigned value from of_property_read_string_index but is
> overwritten before being used so remove it.
> Also fix coverity CID 1309759
You should probably have a line that says
Reported-by: coverity (CID 1309759)
As other similar patches do.
On Tue, Jul 7, 2015 at 10:22 PM, Laurent Navet <[email protected]> wrote:
> ret is assigned value from of_property_read_string_index but is
> overwritten before being used so remove it.
> Also fix coverity CID 1309759
>
> Signed-off-by: Laurent Navet <[email protected]>
Patch applied with Alex' suggested Reported-by tag.
Yours,
Linus Walleij