2015-07-21 05:46:06

by Masahiro Yamada

Subject: [PATCH] gpio: remove unneeded initializer in gpiochip_add_to_list()

This variable is used as an iterator and initialized in the
list_for_each() loop.

Signed-off-by: Masahiro Yamada <[email protected]>
---

drivers/gpio/gpiolib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index bf4bd1d..adb03c6 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -190,7 +190,7 @@ EXPORT_SYMBOL_GPL(gpiod_get_direction);
*/
static int gpiochip_add_to_list(struct gpio_chip *chip)
{
- struct list_head *pos = &gpio_chips;
+ struct list_head *pos;
struct gpio_chip *_chip;
int err = 0;

--
1.9.1

2015-07-21 05:51:12

by Alexandre Courbot

Subject: Re: [PATCH] gpio: remove unneeded initializer in gpiochip_add_to_list()

On Tue, Jul 21, 2015 at 2:45 PM, Masahiro Yamada
<[email protected]> wrote:
> This variable is used as an iterator and initialized in the
> list_for_each() loop.
>

Looks good, thanks!

Reviewed-by: Alexandre Courbot <[email protected]>

> Signed-off-by: Masahiro Yamada <[email protected]>
> ---
>
> drivers/gpio/gpiolib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index bf4bd1d..adb03c6 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -190,7 +190,7 @@ EXPORT_SYMBOL_GPL(gpiod_get_direction);
> */
> static int gpiochip_add_to_list(struct gpio_chip *chip)
> {
> - struct list_head *pos = &gpio_chips;
> + struct list_head *pos;
> struct gpio_chip *_chip;
> int err = 0;
>
> --
> 1.9.1
>

2015-07-27 12:41:01

by Linus Walleij

Subject: Re: [PATCH] gpio: remove unneeded initializer in gpiochip_add_to_list()

On Tue, Jul 21, 2015 at 7:45 AM, Masahiro Yamada
<[email protected]> wrote:

> This variable is used as an iterator and initialized in the
> list_for_each() loop.
>
> Signed-off-by: Masahiro Yamada <[email protected]>

Patch applied with Alex' review tag.

Yours,
Linus Walleij