2016-03-01 21:30:40

by Arnd Bergmann

Subject: Re: [PATCH v2 1/2] mmc: sdhci: Set DMA mask

On Tuesday 01 March 2016 13:32:43 Alexandre Courbot wrote:
> */
> - if (!(host->flags & (SDHCI_USE_SDMA | SDHCI_USE_ADMA))) {
> + if (!(host->flags & (SDHCI_USE_SDMA | SDHCI_USE_ADMA)))
> host->dma_mask = DMA_BIT_MASK(64);
> - mmc_dev(mmc)->dma_mask = &host->dma_mask;
> - }
> +
> + if (host->dma_mask &&
> + dma_set_mask_and_coherent(mmc_dev(mmc), host->dma_mask))
> + pr_warn("%s: cannot set DMA mask\n", mmc_hostname(mmc));
>

Looks good,

Acked-by: Arnd Bergmann <[email protected]>

2016-03-04 06:09:53

by Alexandre Courbot

Subject: Re: [PATCH v2 1/2] mmc: sdhci: Set DMA mask

On Wed, Mar 2, 2016 at 6:30 AM, Arnd Bergmann <[email protected]> wrote:
> On Tuesday 01 March 2016 13:32:43 Alexandre Courbot wrote:
>> */
>> - if (!(host->flags & (SDHCI_USE_SDMA | SDHCI_USE_ADMA))) {
>> + if (!(host->flags & (SDHCI_USE_SDMA | SDHCI_USE_ADMA)))
>> host->dma_mask = DMA_BIT_MASK(64);
>> - mmc_dev(mmc)->dma_mask = &host->dma_mask;
>> - }
>> +
>> + if (host->dma_mask &&
>> + dma_set_mask_and_coherent(mmc_dev(mmc), host->dma_mask))
>> + pr_warn("%s: cannot set DMA mask\n", mmc_hostname(mmc));
>>
>
> Looks good,
>
> Acked-by: Arnd Bergmann <[email protected]>

Withdrawing this patch after discussing with Arnd. The test detects
devices that are not capable of DMA, so it makes no sense to call a
DMA function right after that.

A better solution to the problem this patch tried to solve is on the way.