2018-11-14 12:21:13

by Gerd Hoffmann

Subject: [PATCH] udmabuf: set read/write flag when exporting

Otherwise, mmap fails when done with PROT_WRITE.

Suggested-by: Gurchetan Singh <[email protected]>
Signed-off-by: Gerd Hoffmann <[email protected]>
---
drivers/dma-buf/udmabuf.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c
index e70328ab7e..d9ff246093 100644
--- a/drivers/dma-buf/udmabuf.c
+++ b/drivers/dma-buf/udmabuf.c
@@ -189,6 +189,7 @@ static long udmabuf_create(const struct udmabuf_create_list *head,
exp_info.ops = &udmabuf_ops;
exp_info.size = ubuf->pagecount << PAGE_SHIFT;
exp_info.priv = ubuf;
+ exp_info.flags = O_RDWR;

buf = dma_buf_export(&exp_info);
if (IS_ERR(buf)) {
--
2.9.3

2018-11-16 01:47:47

by Gurchetan Singh

Subject: Re: [PATCH] udmabuf: set read/write flag when exporting

Reviewed-by: Gurchetan Singh <[email protected]>
Tested-by: Gurchetan Singh <[email protected]>
On Wed, Nov 14, 2018 at 4:20 AM Gerd Hoffmann <[email protected]> wrote:
>
> Otherwise, mmap fails when done with PROT_WRITE.
>
> Suggested-by: Gurchetan Singh <[email protected]>
> Signed-off-by: Gerd Hoffmann <[email protected]>
> ---
> drivers/dma-buf/udmabuf.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c
> index e70328ab7e..d9ff246093 100644
> --- a/drivers/dma-buf/udmabuf.c
> +++ b/drivers/dma-buf/udmabuf.c
> @@ -189,6 +189,7 @@ static long udmabuf_create(const struct udmabuf_create_list *head,
> exp_info.ops = &udmabuf_ops;
> exp_info.size = ubuf->pagecount << PAGE_SHIFT;
> exp_info.priv = ubuf;
> + exp_info.flags = O_RDWR;
>
> buf = dma_buf_export(&exp_info);
> if (IS_ERR(buf)) {
> --
> 2.9.3
>

2018-11-16 07:53:12

by Gerd Hoffmann

Subject: Re: [PATCH] udmabuf: set read/write flag when exporting

On Thu, Nov 15, 2018 at 05:46:30PM -0800, Gurchetan Singh wrote:
> Reviewed-by: Gurchetan Singh <[email protected]>
> Tested-by: Gurchetan Singh <[email protected]>

Thanks. Pushed to drm-misc-fixes.

cheers,
Gerd