2022-05-01 17:09:58

by Arnd Bergmann

[permalink] [raw]
Subject: Re: [PATCH V9 16/24] LoongArch: Add misc common routines

On Sat, Apr 30, 2022 at 11:05 AM Huacai Chen <[email protected]> wrote:

> +unsigned long __xchg_small(volatile void *ptr, unsigned long val, unsigned int size)
> +{
> + u32 old32, mask, temp;
> + volatile u32 *ptr32;
> + unsigned int shift;
> +
> + /* Check that ptr is naturally aligned */

As discussed, please remove this function and all the references to it.

Arnd


2022-05-02 23:20:01

by Huacai Chen

[permalink] [raw]
Subject: Re: [PATCH V9 16/24] LoongArch: Add misc common routines

Hi, Arnd,

On Sat, Apr 30, 2022 at 5:50 PM Arnd Bergmann <[email protected]> wrote:
>
> On Sat, Apr 30, 2022 at 11:05 AM Huacai Chen <[email protected]> wrote:
>
> > +unsigned long __xchg_small(volatile void *ptr, unsigned long val, unsigned int size)
> > +{
> > + u32 old32, mask, temp;
> > + volatile u32 *ptr32;
> > + unsigned int shift;
> > +
> > + /* Check that ptr is naturally aligned */
>
> As discussed, please remove this function and all the references to it.
It seems that "generic ticket spinlock" hasn't been merged in 5.18?

Huacai
>
> Arnd