Hi all:
Some liointc-related DTBS_CHECK warnings were found when trying to
introduce the Loongson-2K DTS{I} for LoongArch.
This patch series attempts to fix those warnings.
Of course, these fixes also apply to MIPS Loongson-2K1000.
Thanks.
-----
V6:
- Drop the 'parent_int_map' related patches following Rob's comment.
Link to V5:
https://lore.kernel.org/all/[email protected]/
V5:
- Add Reviewed-by tag;
patch(1/5):
- Just drop 'loongson,parent_int_map' instead of marking it as
deprecated.
Link to V4:
https://lore.kernel.org/all/[email protected]/
V4:
- Add Acked-by tag;
patch(2/5):
- Just add 'maxitem 2' instead of duplicating the list;
patch(3/5):
- Rewite commit message for 'interrupt-names'.
Link to V3:
https://lore.kernel.org/all/[email protected]/
V3:
patch(1/5):
- new patch, 'loongson,parent_int_map' renamed to 'loongson,parent-int-map';
patch(2/5)(3/5):
- Separate the change points into separate patches;
patch(4/5):
- new patch, make sure both parent map forms can be parsed;
patch(5/5):
- new patch, fix 'loongson,parent_int_map' references in mips loongson
dts{i}.
Link to V2:
https://lore.kernel.org/all/[email protected]/
V2:
1. Update commit message;
2. "interruprt-names" should be "required", the driver gets the parent
interrupts through it;
3. Add more descriptions to explain the rationale for multiple nodes;
4. Rewrite if-else statements.
Link to V1:
https://lore.kernel.org/all/[email protected]/
Binbin Zhou (2):
dt-bindings: interrupt-controller: loongson,liointc: Fix dtbs_check
warning for reg-names
dt-bindings: interrupt-controller: loongson,liointc: Fix dtbs_check
warning for interrupt-names
.../interrupt-controller/loongson,liointc.yaml | 18 ++++++++++++------
1 file changed, 12 insertions(+), 6 deletions(-)
--
2.39.3
As we know, the Loongson-2K0500 is a single-core CPU, and the
core1-related register (isr1) does not exist. So "reg" and "reg-names"
should be set to "minItems 2"(main nad isr0).
This fixes dtbs_check warning:
DTC_CHK arch/loongarch/boot/dts/loongson-2k0500-ref.dtb
arch/loongarch/boot/dts/loongson-2k0500-ref.dtb: interrupt-controller@1fe11400: reg-names: ['main', 'isr0'] is too short
From schema: Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml
arch/loongarch/boot/dts/loongson-2k0500-ref.dtb: interrupt-controller@1fe11400: Unevaluated properties are not allowed ('reg-names' was unexpected)
From schema: Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml
arch/loongarch/boot/dts/loongson-2k0500-ref.dtb: interrupt-controller@1fe11400: reg: [[0, 534844416, 0, 64], [0, 534843456, 0, 8]] is too short
From schema: Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml
arch/loongarch/boot/dts/loongson-2k0500-ref.dtb: interrupt-controller@1fe11440: reg-names: ['main', 'isr0'] is too short
From schema: Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml
Signed-off-by: Binbin Zhou <[email protected]>
Acked-by: Jiaxun Yang <[email protected]>
Reviewed-by: Huacai Chen <[email protected]>
Reviewed-by: Rob Herring <[email protected]>
---
.../interrupt-controller/loongson,liointc.yaml | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml b/Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml
index 00b570c82903..a3276c1d9b59 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml
@@ -11,8 +11,13 @@ maintainers:
description: |
This interrupt controller is found in the Loongson-3 family of chips and
- Loongson-2K1000 chip, as the primary package interrupt controller which
+ Loongson-2K series chips, as the primary package interrupt controller which
can route local I/O interrupt to interrupt lines of cores.
+ Be aware of the following points.
+ 1.The Loongson-2K0500 is a single core CPU;
+ 2.The Loongson-2K0500/2K1000 has 64 device interrupt sources as inputs, so we
+ need to define two nodes in dts{i} to describe the "0-31" and "32-61" interrupt
+ sources respectively.
allOf:
- $ref: /schemas/interrupt-controller.yaml#
@@ -33,6 +38,7 @@ properties:
- const: main
- const: isr0
- const: isr1
+ minItems: 2
interrupt-controller: true
@@ -86,7 +92,8 @@ if:
then:
properties:
reg:
- minItems: 3
+ minItems: 2
+ maxItems: 3
required:
- reg-names
--
2.39.3
On 07/12/2023 08:29, Binbin Zhou wrote:
> As we know, the Loongson-2K0500 is a single-core CPU, and the
> core1-related register (isr1) does not exist. So "reg" and "reg-names"
> should be set to "minItems 2"(main nad isr0).
>
> This fixes dtbs_check warning:
>
> DTC_CHK arch/loongarch/boot/dts/loongson-2k0500-ref.dtb
> arch/loongarch/boot/dts/loongson-2k0500-ref.dtb: interrupt-controller@1fe11400: reg-names: ['main', 'isr0'] is too short
> From schema: Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml
> arch/loongarch/boot/dts/loongson-2k0500-ref.dtb: interrupt-controller@1fe11400: Unevaluated properties are not allowed ('reg-names' was unexpected)
> From schema: Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml
> arch/loongarch/boot/dts/loongson-2k0500-ref.dtb: interrupt-controller@1fe11400: reg: [[0, 534844416, 0, 64], [0, 534843456, 0, 8]] is too short
> From schema: Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml
> arch/loongarch/boot/dts/loongson-2k0500-ref.dtb: interrupt-controller@1fe11440: reg-names: ['main', 'isr0'] is too short
> From schema: Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml
>
> Signed-off-by: Binbin Zhou <[email protected]>
> Acked-by: Jiaxun Yang <[email protected]>
> Reviewed-by: Huacai Chen <[email protected]>
> Reviewed-by: Rob Herring <[email protected]>
Where? Point me to exact email on lore.
Didn't we already talk some time ago about fake reviews?
Best regards,
Krzysztof
On 07/12/2023 09:23, Krzysztof Kozlowski wrote:
> On 07/12/2023 08:29, Binbin Zhou wrote:
>> As we know, the Loongson-2K0500 is a single-core CPU, and the
>> core1-related register (isr1) does not exist. So "reg" and "reg-names"
>> should be set to "minItems 2"(main nad isr0).
>>
>> This fixes dtbs_check warning:
>>
>> DTC_CHK arch/loongarch/boot/dts/loongson-2k0500-ref.dtb
>> arch/loongarch/boot/dts/loongson-2k0500-ref.dtb: interrupt-controller@1fe11400: reg-names: ['main', 'isr0'] is too short
>> From schema: Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml
>> arch/loongarch/boot/dts/loongson-2k0500-ref.dtb: interrupt-controller@1fe11400: Unevaluated properties are not allowed ('reg-names' was unexpected)
>> From schema: Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml
>> arch/loongarch/boot/dts/loongson-2k0500-ref.dtb: interrupt-controller@1fe11400: reg: [[0, 534844416, 0, 64], [0, 534843456, 0, 8]] is too short
>> From schema: Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml
>> arch/loongarch/boot/dts/loongson-2k0500-ref.dtb: interrupt-controller@1fe11440: reg-names: ['main', 'isr0'] is too short
>> From schema: Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml
>>
>> Signed-off-by: Binbin Zhou <[email protected]>
>> Acked-by: Jiaxun Yang <[email protected]>
>> Reviewed-by: Huacai Chen <[email protected]>
>> Reviewed-by: Rob Herring <[email protected]>
>
> Where? Point me to exact email on lore.
>
Ah, I see at v4, it's ok:
https://lore.kernel.org/all/[email protected]/
Best regards,
Krzysztof
Hi, Rob,
Since this series doesn't touch the driver any more, I suppose that
this series will go through your dt tree?
Huacai
On Thu, Dec 7, 2023 at 3:29 PM Binbin Zhou <[email protected]> wrote:
>
> Hi all:
>
> Some liointc-related DTBS_CHECK warnings were found when trying to
> introduce the Loongson-2K DTS{I} for LoongArch.
> This patch series attempts to fix those warnings.
>
> Of course, these fixes also apply to MIPS Loongson-2K1000.
>
> Thanks.
>
> -----
> V6:
> - Drop the 'parent_int_map' related patches following Rob's comment.
>
> Link to V5:
> https://lore.kernel.org/all/[email protected]/
>
> V5:
> - Add Reviewed-by tag;
> patch(1/5):
> - Just drop 'loongson,parent_int_map' instead of marking it as
> deprecated.
>
> Link to V4:
> https://lore.kernel.org/all/[email protected]/
>
> V4:
> - Add Acked-by tag;
> patch(2/5):
> - Just add 'maxitem 2' instead of duplicating the list;
> patch(3/5):
> - Rewite commit message for 'interrupt-names'.
>
> Link to V3:
> https://lore.kernel.org/all/[email protected]/
>
> V3:
> patch(1/5):
> - new patch, 'loongson,parent_int_map' renamed to 'loongson,parent-int-map';
> patch(2/5)(3/5):
> - Separate the change points into separate patches;
> patch(4/5):
> - new patch, make sure both parent map forms can be parsed;
> patch(5/5):
> - new patch, fix 'loongson,parent_int_map' references in mips loongson
> dts{i}.
>
> Link to V2:
> https://lore.kernel.org/all/[email protected]/
>
> V2:
> 1. Update commit message;
> 2. "interruprt-names" should be "required", the driver gets the parent
> interrupts through it;
> 3. Add more descriptions to explain the rationale for multiple nodes;
> 4. Rewrite if-else statements.
>
> Link to V1:
> https://lore.kernel.org/all/[email protected]/
>
> Binbin Zhou (2):
> dt-bindings: interrupt-controller: loongson,liointc: Fix dtbs_check
> warning for reg-names
> dt-bindings: interrupt-controller: loongson,liointc: Fix dtbs_check
> warning for interrupt-names
>
> .../interrupt-controller/loongson,liointc.yaml | 18 ++++++++++++------
> 1 file changed, 12 insertions(+), 6 deletions(-)
>
> --
> 2.39.3
>
Applied to loongarch-next, thanks.
Huacai
On Fri, Dec 29, 2023 at 11:08 PM Huacai Chen <[email protected]> wrote:
>
> Hi, Rob,
>
> Since this series doesn't touch the driver any more, I suppose that
> this series will go through your dt tree?
>
> Huacai
>
> On Thu, Dec 7, 2023 at 3:29 PM Binbin Zhou <[email protected]> wrote:
> >
> > Hi all:
> >
> > Some liointc-related DTBS_CHECK warnings were found when trying to
> > introduce the Loongson-2K DTS{I} for LoongArch.
> > This patch series attempts to fix those warnings.
> >
> > Of course, these fixes also apply to MIPS Loongson-2K1000.
> >
> > Thanks.
> >
> > -----
> > V6:
> > - Drop the 'parent_int_map' related patches following Rob's comment.
> >
> > Link to V5:
> > https://lore.kernel.org/all/[email protected]/
> >
> > V5:
> > - Add Reviewed-by tag;
> > patch(1/5):
> > - Just drop 'loongson,parent_int_map' instead of marking it as
> > deprecated.
> >
> > Link to V4:
> > https://lore.kernel.org/all/[email protected]/
> >
> > V4:
> > - Add Acked-by tag;
> > patch(2/5):
> > - Just add 'maxitem 2' instead of duplicating the list;
> > patch(3/5):
> > - Rewite commit message for 'interrupt-names'.
> >
> > Link to V3:
> > https://lore.kernel.org/all/[email protected]/
> >
> > V3:
> > patch(1/5):
> > - new patch, 'loongson,parent_int_map' renamed to 'loongson,parent-int-map';
> > patch(2/5)(3/5):
> > - Separate the change points into separate patches;
> > patch(4/5):
> > - new patch, make sure both parent map forms can be parsed;
> > patch(5/5):
> > - new patch, fix 'loongson,parent_int_map' references in mips loongson
> > dts{i}.
> >
> > Link to V2:
> > https://lore.kernel.org/all/[email protected]/
> >
> > V2:
> > 1. Update commit message;
> > 2. "interruprt-names" should be "required", the driver gets the parent
> > interrupts through it;
> > 3. Add more descriptions to explain the rationale for multiple nodes;
> > 4. Rewrite if-else statements.
> >
> > Link to V1:
> > https://lore.kernel.org/all/[email protected]/
> >
> > Binbin Zhou (2):
> > dt-bindings: interrupt-controller: loongson,liointc: Fix dtbs_check
> > warning for reg-names
> > dt-bindings: interrupt-controller: loongson,liointc: Fix dtbs_check
> > warning for interrupt-names
> >
> > .../interrupt-controller/loongson,liointc.yaml | 18 ++++++++++++------
> > 1 file changed, 12 insertions(+), 6 deletions(-)
> >
> > --
> > 2.39.3
> >