2022-10-18 10:11:08

by Katrin Jo

Subject: [PATCH] LoongArch: use flexible-array member instead of zero-length array

From: Yushan Zhou <[email protected]>

Eliminate the following coccicheck warning:
./arch/loongarch/include/asm/ptrace.h:32:15-21: WARNING use flexible-array member instead

Signed-off-by: Yushan Zhou <[email protected]>
---
arch/loongarch/include/asm/ptrace.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/loongarch/include/asm/ptrace.h b/arch/loongarch/include/asm/ptrace.h
index 17838c6b7ccd..7437b9366c3b 100644
--- a/arch/loongarch/include/asm/ptrace.h
+++ b/arch/loongarch/include/asm/ptrace.h
@@ -29,7 +29,7 @@ struct pt_regs {
unsigned long csr_euen;
unsigned long csr_ecfg;
unsigned long csr_estat;
- unsigned long __last[0];
+ unsigned long __last[];
} __aligned(8);

static inline int regs_irqs_disabled(struct pt_regs *regs)
--
2.27.0

2022-10-18 12:46:33

by Huacai Chen

Subject: Re: [PATCH] LoongArch: use flexible-array member instead of zero-length array

Queued for loongarch-fixes

On Tue, Oct 18, 2022 at 8:27 PM WANG Xuerui <[email protected]> wrote:
>
> On 2022/10/18 17:47, [email protected] wrote:
> > From: Yushan Zhou <[email protected]>
> >
> > Eliminate the following coccicheck warning:
> > ./arch/loongarch/include/asm/ptrace.h:32:15-21: WARNING use flexible-array member instead
> >
> > Signed-off-by: Yushan Zhou <[email protected]>
> > ---
> > arch/loongarch/include/asm/ptrace.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/loongarch/include/asm/ptrace.h b/arch/loongarch/include/asm/ptrace.h
> > index 17838c6b7ccd..7437b9366c3b 100644
> > --- a/arch/loongarch/include/asm/ptrace.h
> > +++ b/arch/loongarch/include/asm/ptrace.h
> > @@ -29,7 +29,7 @@ struct pt_regs {
> > unsigned long csr_euen;
> > unsigned long csr_ecfg;
> > unsigned long csr_estat;
> > - unsigned long __last[0];
> > + unsigned long __last[];
> > } __aligned(8);
> >
> > static inline int regs_irqs_disabled(struct pt_regs *regs)
>
> Seems good. Thanks.
>
> Reviewed-by: WANG Xuerui <[email protected]>
>
> --
> WANG "xen0n" Xuerui
>
> Linux/LoongArch mailing list: https://lore.kernel.org/loongarch/
>
>

2022-10-18 13:01:19

by WANG Xuerui

Subject: Re: [PATCH] LoongArch: use flexible-array member instead of zero-length array

On 2022/10/18 17:47, [email protected] wrote:
> From: Yushan Zhou <[email protected]>
>
> Eliminate the following coccicheck warning:
> ./arch/loongarch/include/asm/ptrace.h:32:15-21: WARNING use flexible-array member instead
>
> Signed-off-by: Yushan Zhou <[email protected]>
> ---
> arch/loongarch/include/asm/ptrace.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/loongarch/include/asm/ptrace.h b/arch/loongarch/include/asm/ptrace.h
> index 17838c6b7ccd..7437b9366c3b 100644
> --- a/arch/loongarch/include/asm/ptrace.h
> +++ b/arch/loongarch/include/asm/ptrace.h
> @@ -29,7 +29,7 @@ struct pt_regs {
> unsigned long csr_euen;
> unsigned long csr_ecfg;
> unsigned long csr_estat;
> - unsigned long __last[0];
> + unsigned long __last[];
> } __aligned(8);
>
> static inline int regs_irqs_disabled(struct pt_regs *regs)

Seems good. Thanks.

Reviewed-by: WANG Xuerui <[email protected]>

--
WANG "xen0n" Xuerui

Linux/LoongArch mailing list: https://lore.kernel.org/loongarch/