2020-12-11 11:34:35

by Joonsoo Kim

[permalink] [raw]
Subject: Re: [PATCH v3] mm/page_owner: Record timestamp and pid

2020년 12월 11일 (금) 오전 1:04, Georgi Djakov <[email protected]>님이 작성:
>
> From: Liam Mark <[email protected]>
>
> Collect the time for each allocation recorded in page owner so that
> allocation "surges" can be measured.
>
> Record the pid for each allocation recorded in page owner so that the
> source of allocation "surges" can be better identified.
>
> The above is very useful when doing memory analysis. On a crash for
> example, we can get this information from kdump (or ramdump) and parse it
> to figure out memory allocation problems.
>
> Please note that on x86_64 this increases the size of struct page_owner
> from 16 bytes to 32.
>
> Vlastimil: it's not a functionality intended for production, so unless
> somebody says they need to enable page_owner for debugging and this
> increase prevents them from fitting into available memory, let's not
> complicate things with making this optional.
>
> Signed-off-by: Liam Mark <[email protected]>
> Signed-off-by: Georgi Djakov <[email protected]>
> Acked-by: Vlastimil Babka <[email protected]>
> Cc: Jonathan Corbet <[email protected]>

Acked-by: Joonsoo Kim <[email protected]>

This is useful. Our company already has an in-house patch to store
pid since a few years ago.

Thanks.