2016-10-07 02:38:59

by Chase Metzger

Subject: [PATCH] drivers: staging: greybus: Fixed CHECKS for brace issues

Added braces to else statements where checkpatch complained.

Signed-off-by: Chase Metzger <[email protected]>
---
drivers/staging/greybus/audio_topology.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/greybus/audio_topology.c b/drivers/staging/greybus/audio_topology.c
index b625169..3a2678e 100644
--- a/drivers/staging/greybus/audio_topology.c
+++ b/drivers/staging/greybus/audio_topology.c
@@ -1044,8 +1044,10 @@ static int gbaudio_tplg_create_widget(struct gbaudio_module_info *module,
control->texts = (const char * const *)
gb_generate_enum_strings(module, gbenum);
control->items = gbenum->items;
- } else
+ } else {
csize = sizeof(struct gb_audio_control);
+ }
+
*w_size += csize;
curr = (void *)curr + csize;
list_add(&control->list, &module->widget_ctl_list);
@@ -1190,8 +1192,9 @@ static int gbaudio_tplg_process_kcontrols(struct gbaudio_module_info *module,
control->texts = (const char * const *)
gb_generate_enum_strings(module, gbenum);
control->items = gbenum->items;
- } else
+ } else {
csize = sizeof(struct gb_audio_control);
+ }

list_add(&control->list, &module->ctl_list);
dev_dbg(module->dev, "%d:%s created of type %d\n", curr->id,
--
2.1.4

2016-10-07 03:24:54

by Viresh Kumar

Subject: Re: [PATCH] drivers: staging: greybus: Fixed CHECKS for brace issues

On Fri, Oct 7, 2016 at 8:08 AM, Chase Metzger <[email protected]> wrote:
> Added braces to else statements where checkpatch complained.
>
> Signed-off-by: Chase Metzger <[email protected]>
> ---
> drivers/staging/greybus/audio_topology.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)

Acked-by: Viresh Kumar <[email protected]>

2016-10-07 03:46:20

by Vaibhav Agarwal

Subject: Re: [PATCH] drivers: staging: greybus: Fixed CHECKS for brace issues

On Fri, Oct 7, 2016 at 8:08 AM, Chase Metzger <[email protected]> wrote:
> Added braces to else statements where checkpatch complained.
>
> Signed-off-by: Chase Metzger <[email protected]>
> ---

Reviewed-by: Vaibhav Agarwal <[email protected]>