2018-04-06 11:10:53

by Gaurav Dhingra

Subject: [PATCH v3] staging: greybus: Fix warning to limit chars per line

Wrap comment to fix warning "prefer a maximum 75 chars per line"

Signed-off-by: Gaurav Dhingra <[email protected]>
---
Changes in v2:
- use correct format for multiline comment
Changes in v3:
- include commit log
---
drivers/staging/greybus/audio_codec.h | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/audio_codec.h b/drivers/staging/greybus/audio_codec.h
index a1d5440..4efd8b3 100644
--- a/drivers/staging/greybus/audio_codec.h
+++ b/drivers/staging/greybus/audio_codec.h
@@ -23,7 +23,10 @@ enum {
NUM_CODEC_DAIS,
};

-/* device_type should be same as defined in audio.h (Android media layer) */
+/*
+ * device_type should be same as defined in audio.h
+ * (Android media layer)
+ */
enum {
GBAUDIO_DEVICE_NONE = 0x0,
/* reserved bits */
--
1.9.1

2018-04-06 11:19:35

by Vaibhav Agarwal

Subject: Re: [PATCH v3] staging: greybus: Fix warning to limit chars per line

On Fri, Apr 6, 2018 at 4:39 PM, Gaurav Dhingra
<[email protected]> wrote:
> Wrap comment to fix warning "prefer a maximum 75 chars per line"
>
> Signed-off-by: Gaurav Dhingra <[email protected]>
> ---
> Changes in v2:
> - use correct format for multiline comment
> Changes in v3:
> - include commit log
> ---
> drivers/staging/greybus/audio_codec.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/audio_codec.h b/drivers/staging/greybus/audio_codec.h
> index a1d5440..4efd8b3 100644
> --- a/drivers/staging/greybus/audio_codec.h
> +++ b/drivers/staging/greybus/audio_codec.h
> @@ -23,7 +23,10 @@ enum {
> NUM_CODEC_DAIS,
> };
>
> -/* device_type should be same as defined in audio.h (Android media layer) */
> +/*
> + * device_type should be same as defined in audio.h
> + * (Android media layer)
> + */

Acked-by: Vaibhav Agarwal <[email protected]>

--
thanks,
./va

2018-04-06 16:08:58

by Mark Greer

Subject: Re: [PATCH v3] staging: greybus: Fix warning to limit chars per line

On Fri, Apr 06, 2018 at 04:39:22PM +0530, Gaurav Dhingra wrote:
> Wrap comment to fix warning "prefer a maximum 75 chars per line"
>
> Signed-off-by: Gaurav Dhingra <[email protected]>
> ---
> Changes in v2:
> - use correct format for multiline comment
> Changes in v3:
> - include commit log
> ---
> drivers/staging/greybus/audio_codec.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/audio_codec.h b/drivers/staging/greybus/audio_codec.h
> index a1d5440..4efd8b3 100644
> --- a/drivers/staging/greybus/audio_codec.h
> +++ b/drivers/staging/greybus/audio_codec.h
> @@ -23,7 +23,10 @@ enum {
> NUM_CODEC_DAIS,
> };
>
> -/* device_type should be same as defined in audio.h (Android media layer) */
> +/*
> + * device_type should be same as defined in audio.h
> + * (Android media layer)
> + */
> enum {
> GBAUDIO_DEVICE_NONE = 0x0,
> /* reserved bits */
> --
> 1.9.1

Reviewed-by: Mark Greer <[email protected]>