2015-06-02 06:41:01

by Michal Simek

Subject: [PATCH] char:xilinx_hwicap:buffer_icap - change 1/0 to true/false for bool type variable in function buffer_icap_set_configuration().

From: Shailendra Verma <[email protected]>

The variable dirty is bool type. Hence assign the variable with
bool value true/false instead of 1/0.

Signed-off-by: Shailendra Verma <[email protected]>
Tested-by: Michal Simek <[email protected]>
---

drivers/char/xilinx_hwicap/buffer_icap.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/char/xilinx_hwicap/buffer_icap.c b/drivers/char/xilinx_hwicap/buffer_icap.c
index 05d897764f02..53c3882e4981 100644
--- a/drivers/char/xilinx_hwicap/buffer_icap.c
+++ b/drivers/char/xilinx_hwicap/buffer_icap.c
@@ -270,7 +270,7 @@ int buffer_icap_set_configuration(struct hwicap_drvdata *drvdata, u32 *data,
int status;
s32 buffer_count = 0;
s32 num_writes = 0;
- bool dirty = 0;
+ bool dirty = false;
u32 i;
void __iomem *base_address = drvdata->base_address;

@@ -279,7 +279,7 @@ int buffer_icap_set_configuration(struct hwicap_drvdata *drvdata, u32 *data,

/* Copy data to bram */
buffer_icap_set_bram(base_address, buffer_count, data[i]);
- dirty = 1;
+ dirty = true;

if (buffer_count < XHI_MAX_BUFFER_INTS - 1) {
buffer_count++;
@@ -299,7 +299,7 @@ int buffer_icap_set_configuration(struct hwicap_drvdata *drvdata, u32 *data,

buffer_count = 0;
num_writes++;
- dirty = 0;
+ dirty = false;
}

/* Write unwritten data to ICAP */
--
2.3.5

2015-06-02 16:52:09

by Moritz Fischer

Subject: Re: [PATCH] char:xilinx_hwicap:buffer_icap - change 1/0 to true/false for bool type variable in function buffer_icap_set_configuration().

On Mon, Jun 1, 2015 at 11:40 PM, Michal Simek <[email protected]> wrote:
> From: Shailendra Verma <[email protected]>
>
> The variable dirty is bool type. Hence assign the variable with
> bool value true/false instead of 1/0.
>
> Signed-off-by: Shailendra Verma <[email protected]>
> Tested-by: Michal Simek <[email protected]>
Feel free to add:
Acked-by: Moritz Fischer <[email protected]>
> ---
>
> drivers/char/xilinx_hwicap/buffer_icap.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/char/xilinx_hwicap/buffer_icap.c b/drivers/char/xilinx_hwicap/buffer_icap.c
> index 05d897764f02..53c3882e4981 100644
> --- a/drivers/char/xilinx_hwicap/buffer_icap.c
> +++ b/drivers/char/xilinx_hwicap/buffer_icap.c
> @@ -270,7 +270,7 @@ int buffer_icap_set_configuration(struct hwicap_drvdata *drvdata, u32 *data,
> int status;
> s32 buffer_count = 0;
> s32 num_writes = 0;
> - bool dirty = 0;
> + bool dirty = false;
> u32 i;
> void __iomem *base_address = drvdata->base_address;
>
> @@ -279,7 +279,7 @@ int buffer_icap_set_configuration(struct hwicap_drvdata *drvdata, u32 *data,
>
> /* Copy data to bram */
> buffer_icap_set_bram(base_address, buffer_count, data[i]);
> - dirty = 1;
> + dirty = true;
>
> if (buffer_count < XHI_MAX_BUFFER_INTS - 1) {
> buffer_count++;
> @@ -299,7 +299,7 @@ int buffer_icap_set_configuration(struct hwicap_drvdata *drvdata, u32 *data,
>
> buffer_count = 0;
> num_writes++;
> - dirty = 0;
> + dirty = false;
> }
>
> /* Write unwritten data to ICAP */
> --
> 2.3.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/