2018-11-29 23:11:43

by Colin King

Subject: [PATCH] fpga: mgr: altera-ps-spi: make array dummy static, shrinks object size

From: Colin Ian King <[email protected]>

Don't populate the const array dummy on the stack but instead
make it static. Makes the object code smaller by 26 bytes:

Before:
text data bss dec hex filename
7371 2032 0 9403 24bb drivers/fpga/altera-ps-spi.o

After:
text data bss dec hex filename
7281 2096 0 9377 24a1 drivers/fpga/altera-ps-spi.o

(gcc version 8.2.0 x86_64)

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/fpga/altera-ps-spi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/fpga/altera-ps-spi.c b/drivers/fpga/altera-ps-spi.c
index 8c18beec6b57..678d0115f840 100644
--- a/drivers/fpga/altera-ps-spi.c
+++ b/drivers/fpga/altera-ps-spi.c
@@ -205,7 +205,7 @@ static int altera_ps_write_complete(struct fpga_manager *mgr,
struct fpga_image_info *info)
{
struct altera_ps_conf *conf = mgr->priv;
- const char dummy[] = {0};
+ static const char dummy[] = {0};
int ret;

if (gpiod_get_value_cansleep(conf->status)) {
--
2.19.1

2019-01-24 16:49:31

by Colin King

Subject: Re: [PATCH] fpga: mgr: altera-ps-spi: make array dummy static, shrinks object size

ping?

On 29/11/2018 23:10, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> Don't populate the const array dummy on the stack but instead
> make it static. Makes the object code smaller by 26 bytes:
>
> Before:
> text data bss dec hex filename
> 7371 2032 0 9403 24bb drivers/fpga/altera-ps-spi.o
>
> After:
> text data bss dec hex filename
> 7281 2096 0 9377 24a1 drivers/fpga/altera-ps-spi.o
>
> (gcc version 8.2.0 x86_64)
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/fpga/altera-ps-spi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/altera-ps-spi.c b/drivers/fpga/altera-ps-spi.c
> index 8c18beec6b57..678d0115f840 100644
> --- a/drivers/fpga/altera-ps-spi.c
> +++ b/drivers/fpga/altera-ps-spi.c
> @@ -205,7 +205,7 @@ static int altera_ps_write_complete(struct fpga_manager *mgr,
> struct fpga_image_info *info)
> {
> struct altera_ps_conf *conf = mgr->priv;
> - const char dummy[] = {0};
> + static const char dummy[] = {0};
> int ret;
>
> if (gpiod_get_value_cansleep(conf->status)) {
>

2019-01-24 17:17:33

by Alan Tull

Subject: Re: [PATCH] fpga: mgr: altera-ps-spi: make array dummy static, shrinks object size

On Thu, Nov 29, 2018 at 5:10 PM Colin King <[email protected]> wrote:

Hi Colin,

Thanks!

>
> From: Colin Ian King <[email protected]>
>
> Don't populate the const array dummy on the stack but instead
> make it static. Makes the object code smaller by 26 bytes:
>
> Before:
> text data bss dec hex filename
> 7371 2032 0 9403 24bb drivers/fpga/altera-ps-spi.o
>
> After:
> text data bss dec hex filename
> 7281 2096 0 9377 24a1 drivers/fpga/altera-ps-spi.o
>
> (gcc version 8.2.0 x86_64)
>
> Signed-off-by: Colin Ian King <[email protected]>

Acked-by: Alan Tull <[email protected]>


> ---
> drivers/fpga/altera-ps-spi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/altera-ps-spi.c b/drivers/fpga/altera-ps-spi.c
> index 8c18beec6b57..678d0115f840 100644
> --- a/drivers/fpga/altera-ps-spi.c
> +++ b/drivers/fpga/altera-ps-spi.c
> @@ -205,7 +205,7 @@ static int altera_ps_write_complete(struct fpga_manager *mgr,
> struct fpga_image_info *info)
> {
> struct altera_ps_conf *conf = mgr->priv;
> - const char dummy[] = {0};
> + static const char dummy[] = {0};
> int ret;
>
> if (gpiod_get_value_cansleep(conf->status)) {
> --
> 2.19.1
>

2019-01-24 17:32:50

by Moritz Fischer

Subject: Re: [PATCH] fpga: mgr: altera-ps-spi: make array dummy static, shrinks object size

Hi Colin,

sorry dropped of my radar.

On Thu, Jan 24, 2019 at 9:17 AM Alan Tull <[email protected]> wrote:
>
> On Thu, Nov 29, 2018 at 5:10 PM Colin King <[email protected]> wrote:
>
> Hi Colin,
>
> Thanks!
>
> >
> > From: Colin Ian King <[email protected]>
> >
> > Don't populate the const array dummy on the stack but instead
> > make it static. Makes the object code smaller by 26 bytes:
> >
> > Before:
> > text data bss dec hex filename
> > 7371 2032 0 9403 24bb drivers/fpga/altera-ps-spi.o
> >
> > After:
> > text data bss dec hex filename
> > 7281 2096 0 9377 24a1 drivers/fpga/altera-ps-spi.o
> >
> > (gcc version 8.2.0 x86_64)
> >
> > Signed-off-by: Colin Ian King <[email protected]>
>
> Acked-by: Alan Tull <[email protected]>
Acked-by: Moritz Fischer <[email protected]>

>
>
> > ---
> > drivers/fpga/altera-ps-spi.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/fpga/altera-ps-spi.c b/drivers/fpga/altera-ps-spi.c
> > index 8c18beec6b57..678d0115f840 100644
> > --- a/drivers/fpga/altera-ps-spi.c
> > +++ b/drivers/fpga/altera-ps-spi.c
> > @@ -205,7 +205,7 @@ static int altera_ps_write_complete(struct fpga_manager *mgr,
> > struct fpga_image_info *info)
> > {
> > struct altera_ps_conf *conf = mgr->priv;
> > - const char dummy[] = {0};
> > + static const char dummy[] = {0};
> > int ret;
> >
> > if (gpiod_get_value_cansleep(conf->status)) {
> > --
> > 2.19.1
> >

Moritz