2013-07-09 15:21:35

by Cristian Bercaru

Subject: [PATCH] invoke arguments the right way in coccinelle script

Because the command line arguments were invoked incorrectly
'make coccicheck' failed to run 'irqf_oneshot.cocci' and all tests that
followed. Fixed that.

Signed-off-by: Cristian Bercaru <[email protected]>
---
scripts/coccinelle/misc/irqf_oneshot.cocci | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/coccinelle/misc/irqf_oneshot.cocci b/scripts/coccinelle/misc/irqf_oneshot.cocci
index 6cfde94..5cca680 100644
--- a/scripts/coccinelle/misc/irqf_oneshot.cocci
+++ b/scripts/coccinelle/misc/irqf_oneshot.cocci
@@ -4,7 +4,7 @@
//
// Confidence: Good
// Comments:
-// Options: --no-includes
+// Options: -no_includes

virtual patch
virtual context
--
1.7.11.7

2013-07-09 16:11:50

by Lars-Peter Clausen

Subject: Re: [Cocci] [PATCH] invoke arguments the right way in coccinelle script

On 07/09/2013 05:21 PM, Cristian Bercaru wrote:
> Because the command line arguments were invoked incorrectly
> 'make coccicheck' failed to run 'irqf_oneshot.cocci' and all tests that
> followed. Fixed that.
>
> Signed-off-by: Cristian Bercaru <[email protected]>

Time to update your coccinelle installation ;)

--no-include is support in new versions and is prefered over -no_includes

> ---
> scripts/coccinelle/misc/irqf_oneshot.cocci | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/coccinelle/misc/irqf_oneshot.cocci b/scripts/coccinelle/misc/irqf_oneshot.cocci
> index 6cfde94..5cca680 100644
> --- a/scripts/coccinelle/misc/irqf_oneshot.cocci
> +++ b/scripts/coccinelle/misc/irqf_oneshot.cocci
> @@ -4,7 +4,7 @@
> //
> // Confidence: Good
> // Comments:
> -// Options: --no-includes
> +// Options: -no_includes
>
> virtual patch
> virtual context

2013-07-10 05:53:42

by Nicolas Palix (LIG)

Subject: Re: [Cocci] [PATCH] invoke arguments the right way in coccinelle script

Hi Cristian,

You need Coccinelle version 1.0.0-rc11 or above. I think the minimal
required version
is about one year old.

For more information see Documentation/coccinelle.txt which have been updated.
If you prefer to stick to your current version, the commits to revert
are the following ones

ec97946ed038f4b3faa587bc76152b198805b0c4
93f14468491747d6d3efd0b3a42785b1d51a127a

Regards,


On Tue, Jul 9, 2013 at 6:12 PM, Lars-Peter Clausen <[email protected]> wrote:
> On 07/09/2013 05:21 PM, Cristian Bercaru wrote:
>> Because the command line arguments were invoked incorrectly
>> 'make coccicheck' failed to run 'irqf_oneshot.cocci' and all tests that
>> followed. Fixed that.
>>
>> Signed-off-by: Cristian Bercaru <[email protected]>
>
> Time to update your coccinelle installation ;)
>
> --no-include is support in new versions and is prefered over -no_includes
>
>> ---
>> scripts/coccinelle/misc/irqf_oneshot.cocci | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/coccinelle/misc/irqf_oneshot.cocci b/scripts/coccinelle/misc/irqf_oneshot.cocci
>> index 6cfde94..5cca680 100644
>> --- a/scripts/coccinelle/misc/irqf_oneshot.cocci
>> +++ b/scripts/coccinelle/misc/irqf_oneshot.cocci
>> @@ -4,7 +4,7 @@
>> //
>> // Confidence: Good
>> // Comments:
>> -// Options: --no-includes
>> +// Options: -no_includes
>>
>> virtual patch
>> virtual context
>
> _______________________________________________
> Cocci mailing list
> [email protected]
> https://systeme.lip6.fr/mailman/listinfo/cocci



--
Nicolas Palix
Tel: +33 4 76 51 46 27
http://membres-liglab.imag.fr/palix/