2017-06-09 18:55:09

by Srishti Sharma

[permalink] [raw]
Subject: [PATCH] Staging: ks7010: ks_hostif.c: Fixed alignment to match open parenthesis

Fixed alignment so that it matched open paranthesis .

Signed-off-by: srishti sharma <[email protected]>
---
drivers/staging/ks7010/ks_hostif.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
index 697347b..e3c11be 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -1659,8 +1659,8 @@ void hostif_phy_information_request(struct ks_wlan_private *priv)

static
void hostif_power_mgmt_request(struct ks_wlan_private *priv,
- unsigned long mode, unsigned long wake_up,
- unsigned long receive_dtims)
+ unsigned long mode, unsigned long wake_up,
+ unsigned long receive_dtims)
{
struct hostif_power_mgmt_request_t *pp;

--
2.7.4


2017-06-09 19:03:59

by Srishti Sharma

[permalink] [raw]
Subject: Re: [PATCH] Staging: ks7010: ks_hostif.c: Fixed alignment to match open parenthesis

On Sat, Jun 10, 2017 at 12:25 AM, srishti sharma <[email protected]> wrote:
> Fixed alignment so that it matched open paranthesis .
>
> Signed-off-by: srishti sharma <[email protected]>
> ---
> drivers/staging/ks7010/ks_hostif.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
> index 697347b..e3c11be 100644
> --- a/drivers/staging/ks7010/ks_hostif.c
> +++ b/drivers/staging/ks7010/ks_hostif.c
> @@ -1659,8 +1659,8 @@ void hostif_phy_information_request(struct ks_wlan_private *priv)
>
> static
> void hostif_power_mgmt_request(struct ks_wlan_private *priv,
> - unsigned long mode, unsigned long wake_up,
> - unsigned long receive_dtims)
> + unsigned long mode, unsigned long wake_up,
> + unsigned long receive_dtims)
> {
> struct hostif_power_mgmt_request_t *pp;
>
> --
> 2.7.4

Okay , this doesn't look right , please ignore ! Sorry

Thanks
Srishti

2017-06-12 12:24:21

by Dan Carpenter

[permalink] [raw]
Subject: Re: [PATCH] Staging: ks7010: ks_hostif.c: Fixed alignment to match open parenthesis

On Sat, Jun 10, 2017 at 12:33:57AM +0530, srishti sharma wrote:
> On Sat, Jun 10, 2017 at 12:25 AM, srishti sharma <[email protected]> wrote:
> > Fixed alignment so that it matched open paranthesis .
> >
> > Signed-off-by: srishti sharma <[email protected]>
^ ^

You're the opposite of me. My mama named me with capital letters but
informally I sometimes use lower case. Your formal name is lower case
but informally you use caps. :P

>
> Okay , this doesn't look right , please ignore ! Sorry
>

It actually is correct, it just looks wrong in the diff because of the
extra " +-" character at the beginning of the line.

> Thanks
> Srishti

regards,
dan carpenter

2017-06-12 12:46:32

by Srishti Sharma

[permalink] [raw]
Subject: Re: [PATCH] Staging: ks7010: ks_hostif.c: Fixed alignment to match open parenthesis

On Mon, Jun 12, 2017 at 5:53 PM, Dan Carpenter <[email protected]> wrote:
> On Sat, Jun 10, 2017 at 12:33:57AM +0530, srishti sharma wrote:
>> On Sat, Jun 10, 2017 at 12:25 AM, srishti sharma <[email protected]> wrote:
>> > Fixed alignment so that it matched open paranthesis .
>> >
>> > Signed-off-by: srishti sharma <[email protected]>
> ^ ^
>
> You're the opposite of me. My mama named me with capital letters but
> informally I sometimes use lower case. Your formal name is lower case
> but informally you use caps. :P
>
>>
>> Okay , this doesn't look right , please ignore ! Sorry
>>
>
> It actually is correct, it just looks wrong in the diff because of the
> extra " +-" character at the beginning of the line.
>
>> Thanks
>> Srishti
>
> regards,
> dan carpenter
>


Hey,

Thanks :) , so will this be accepted ?

Regards,
Srishti

2017-06-12 13:18:02

by Dan Carpenter

[permalink] [raw]
Subject: Re: [PATCH] Staging: ks7010: ks_hostif.c: Fixed alignment to match open parenthesis

On Mon, Jun 12, 2017 at 06:16:30PM +0530, srishti sharma wrote:
>
> Thanks :) , so will this be accepted ?
>

Probably, yes. Unless Greg has already dropped it because you said to
drop it.

regards,
dan carpenter

2017-06-12 13:19:46

by Srishti Sharma

[permalink] [raw]
Subject: Re: [PATCH] Staging: ks7010: ks_hostif.c: Fixed alignment to match open parenthesis

On Mon, Jun 12, 2017 at 6:47 PM, Dan Carpenter <[email protected]> wrote:
> On Mon, Jun 12, 2017 at 06:16:30PM +0530, srishti sharma wrote:
>>
>> Thanks :) , so will this be accepted ?
>>
>
> Probably, yes. Unless Greg has already dropped it because you said to
> drop it.
>
> regards,
> dan carpenter
>


Okay, Thanks :)

Regards,
srishti