2017-09-06 19:24:49

by Srishti Sharma

Subject: [PATCH] Staging: ccree: ssi_cipher.c: Correct spelling mistake.

Correct spelling of counter in comment .

Signed-off-by: Srishti Sharma <[email protected]>
---
drivers/staging/ccree/ssi_cipher.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/ccree/ssi_cipher.c b/drivers/staging/ccree/ssi_cipher.c
index 8d31a93..99232b2 100644
--- a/drivers/staging/ccree/ssi_cipher.c
+++ b/drivers/staging/ccree/ssi_cipher.c
@@ -702,7 +702,7 @@ static int ssi_blkcipher_complete(struct device *dev,

ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, dst);

- /*Set the inflight couter value to local variable*/
+ /*Set the inflight counter value to local variable*/
inflight_counter = ctx_p->drvdata->inflight_counter;
/*Decrease the inflight counter*/
if (ctx_p->flow_mode == BYPASS && ctx_p->drvdata->inflight_counter > 0)
--
2.7.4

2017-09-06 21:00:20

by Dan Carpenter

Subject: Re: [PATCH] Staging: ccree: ssi_cipher.c: Correct spelling mistake.

On Thu, Sep 07, 2017 at 12:54:23AM +0530, Srishti Sharma wrote:
> Correct spelling of counter in comment .
>
> Signed-off-by: Srishti Sharma <[email protected]>
> ---
> drivers/staging/ccree/ssi_cipher.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/ccree/ssi_cipher.c b/drivers/staging/ccree/ssi_cipher.c
> index 8d31a93..99232b2 100644
> --- a/drivers/staging/ccree/ssi_cipher.c
> +++ b/drivers/staging/ccree/ssi_cipher.c
> @@ -702,7 +702,7 @@ static int ssi_blkcipher_complete(struct device *dev,
>
> ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, dst);
>
> - /*Set the inflight couter value to local variable*/
> + /*Set the inflight counter value to local variable*/
> inflight_counter = ctx_p->drvdata->inflight_counter;

Sure, but it would be better to just delete the comment. It's obvious.
But really just delete the local inflight_counter variable as well
because that's never used.

regards,
dan carpenter

2017-09-06 21:02:57

by Srishti Sharma

Subject: Re: [PATCH] Staging: ccree: ssi_cipher.c: Correct spelling mistake.

On Thu, Sep 7, 2017 at 2:29 AM, Dan Carpenter <[email protected]> wrote:
> On Thu, Sep 07, 2017 at 12:54:23AM +0530, Srishti Sharma wrote:
>> Correct spelling of counter in comment .
>>
>> Signed-off-by: Srishti Sharma <[email protected]>
>> ---
>> drivers/staging/ccree/ssi_cipher.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/ccree/ssi_cipher.c b/drivers/staging/ccree/ssi_cipher.c
>> index 8d31a93..99232b2 100644
>> --- a/drivers/staging/ccree/ssi_cipher.c
>> +++ b/drivers/staging/ccree/ssi_cipher.c
>> @@ -702,7 +702,7 @@ static int ssi_blkcipher_complete(struct device *dev,
>>
>> ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, dst);
>>
>> - /*Set the inflight couter value to local variable*/
>> + /*Set the inflight counter value to local variable*/
>> inflight_counter = ctx_p->drvdata->inflight_counter;
>
> Sure, but it would be better to just delete the comment. It's obvious.
> But really just delete the local inflight_counter variable as well
> because that's never used.

Okay, I'll delete it .
>
> regards,
> dan carpenter
>

Regards,
Srishti