2017-12-22 00:35:56

by Colin King

Subject: [PATCH] nfsd: fix incorrect indentation on goto statement

From: Colin Ian King <[email protected]>

The goto statement requires one more level of indentation, add it.

Signed-off-by: Colin Ian King <[email protected]>
---
fs/nfsd/nfs4state.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index b29b5a185a2c..3bb720a59b49 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -6159,7 +6159,7 @@ nfsd4_lockt(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
default:
dprintk("NFSD: nfs4_lockt: bad lock type!\n");
status = nfserr_inval;
- goto out;
+ goto out;
}

lo = find_lockowner_str(cstate->clp, &lockt->lt_owner);
--
2.14.1

2017-12-22 01:11:42

by Kinglong Mee

Subject: Re: [PATCH] nfsd: fix incorrect indentation on goto statement

On Fri, Dec 22, 2017 at 8:35 AM, Colin King <[email protected]> wrote:
> From: Colin Ian King <[email protected]>
>
> The goto statement requires one more level of indentation, add it.

Those "break" in this switch need one more level too,
it's nice to add them in this patch.

thanks,
Kinglong Mee

>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> fs/nfsd/nfs4state.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index b29b5a185a2c..3bb720a59b49 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -6159,7 +6159,7 @@ nfsd4_lockt(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
> default:
> dprintk("NFSD: nfs4_lockt: bad lock type!\n");
> status = nfserr_inval;
> - goto out;
> + goto out;
> }
>
> lo = find_lockowner_str(cstate->clp, &lockt->lt_owner);
> --
> 2.14.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html