2023-09-21 17:17:18

by Andy Shevchenko

Subject: Re: [PATCH V2 2/4] gpio: sprd: Clear interrupt after set the interrupt type

On Thu, Sep 21, 2023 at 05:00:25PM +0800, Wenhua Lin wrote:
> The initialization state of the EIC module is a high level trigger.

Here you use EIC, in other places eic. Can you, please, be consistent?

> If it is currently a high level, the interrupt condition is met at
> this time, and the EIC interrupt has a latch capability, which will
> cause an interrupt to occur after booting. To avoid this, When setting
> the EIC interrupt trigger type, clear the interrupt once.

--
With Best Regards,
Andy Shevchenko

2024-01-03 12:06:42

by wenhua lin

Subject: Re: [PATCH V2 2/4] gpio: sprd: Clear interrupt after set the interrupt type

On Thu, Sep 21, 2023 at 7:24 PM Andy Shevchenko <[email protected]> wrote:
>
> On Thu, Sep 21, 2023 at 05:00:25PM +0800, Wenhua Lin wrote:
> > The initialization state of the EIC module is a high level trigger.
>
> Here you use EIC, in other places eic. Can you, please, be consistent?

Thank you very much for your review.
I will fix this issue in patch v3.

>
> > If it is currently a high level, the interrupt condition is met at
> > this time, and the EIC interrupt has a latch capability, which will
> > cause an interrupt to occur after booting. To avoid this, When setting
> > the EIC interrupt trigger type, clear the interrupt once.
>
> --
> With Best Regards,
> Andy Shevchenko
>
>