On Tue, Mar 19, 2024 at 5:02 PM Luiz Augusto von Dentz
<[email protected]> wrote:
>
> Hi,
>
> On Tue, Mar 19, 2024 at 4:26 PM Johan Hovold <[email protected]> wrote:
> >
> > On Tue, Mar 19, 2024 at 09:10:23AM -0700, Doug Anderson wrote:
> > > On Tue, Mar 19, 2024 at 8:29 AM Johan Hovold <[email protected]> wrote:
> >
> > > > + /* When this quirk is set, the Bluetooth Device Address provided by
> > > > + * the 'local-bd-address' fwnode property is incorrectly specified in
> > > > + * big-endian order.
> > > > + *
> > > > + * This quirk can be set before hci_register_dev is called or
> > > > + * during the hdev->setup vendor callback.
> > > > + */
> > > > + HCI_QUIRK_BDADDR_PROPERTY_BROKEN,
> > >
> > > Like with the binding, I feel like
> > > "HCI_QUIRK_BDADDR_PROPERTY_BACKWARDS" or
> > > "HCI_QUIRK_BDADDR_PROPERTY_SWAPPED" would be more documenting but I
> > > don't feel strongly.
> >
> > So, same reasoning here, this it not some quirk that people should go
> > around setting without first considering to fix their boot firmware.
>
> Or we just change its meaning to say what byteorder is the BDADDR e.g:
> HCI_QUIRK_BDADDR_PROPERTY_BYTEORDER=be
Ah just ignore, it is a flag not really a property that can assume
different values.
> > Johan
>
>
>
> --
> Luiz Augusto von Dentz
--
Luiz Augusto von Dentz