2021-08-30 03:57:35

by Yu-Tung Chang

[permalink] [raw]
Subject: [PATCH] rtc: rx8010: select REGMAP_I2C

From 45801967ad80578161485937a0833b27b90210f9 Mon Sep 17 00:00:00 2001
From: Yu-Tung Chang <[email protected]>
Date: Mon, 30 Aug 2021 10:59:17 +0800
Subject: [PATCH] rtc: rx8010: select REGMAP_I2C

The rtc-rx8010 uses the I2C regmap but doesn't select it in Kconfig so
depending on the configuration the build may fail. Fix it.

Signed-off-by: Yu-Tung Chang <[email protected]>
---
drivers/rtc/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
index 12153d5801ce..f7bf87097a9f 100644
--- a/drivers/rtc/Kconfig
+++ b/drivers/rtc/Kconfig
@@ -624,6 +624,7 @@ config RTC_DRV_FM3130

config RTC_DRV_RX8010
tristate "Epson RX8010SJ"
+ select REGMAP_I2C
help
If you say yes here you get support for the Epson RX8010SJ RTC
chip.
--
2.33.0


2021-09-10 01:08:41

by Nobuhiro Iwamatsu

[permalink] [raw]
Subject: Re: [PATCH] rtc: rx8010: select REGMAP_I2C

Hi,

2021年8月30日(月) 12:56 Yu-Tung Chang <[email protected]>:
>
> From 45801967ad80578161485937a0833b27b90210f9 Mon Sep 17 00:00:00 2001
> From: Yu-Tung Chang <[email protected]>
> Date: Mon, 30 Aug 2021 10:59:17 +0800
> Subject: [PATCH] rtc: rx8010: select REGMAP_I2C
>
> The rtc-rx8010 uses the I2C regmap but doesn't select it in Kconfig so
> depending on the configuration the build may fail. Fix it.
>
> Signed-off-by: Yu-Tung Chang <[email protected]>
> ---
> drivers/rtc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)

Reviewed-by: Nobuhiro Iwamatsu <[email protected]>

>
> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> index 12153d5801ce..f7bf87097a9f 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -624,6 +624,7 @@ config RTC_DRV_FM3130
>
> config RTC_DRV_RX8010
> tristate "Epson RX8010SJ"
> + select REGMAP_I2C
> help
> If you say yes here you get support for the Epson RX8010SJ RTC
> chip.
> --
> 2.33.0

Best regards,
Nobuhiro

--
Nobuhiro Iwamatsu
iwamatsu at {nigauri.org / debian.org / kernel.org}
GPG ID: 40AD1FA6