2022-05-09 08:39:15

by CGEL

Subject: [PATCH] rtc: simplify the return expression of rx8025_set_offset()

From: Minghao Chi <[email protected]>

Simplify the return expression.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Minghao Chi <[email protected]>
---
drivers/rtc/rtc-rx8025.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/rtc/rtc-rx8025.c b/drivers/rtc/rtc-rx8025.c
index 5bfdd34a72ff..b32117ccd74b 100644
--- a/drivers/rtc/rtc-rx8025.c
+++ b/drivers/rtc/rtc-rx8025.c
@@ -436,7 +436,6 @@ static int rx8025_set_offset(struct device *dev, long offset)
{
struct i2c_client *client = to_i2c_client(dev);
u8 digoff;
- int err;

offset /= RX8025_ADJ_RESOLUTION;
if (offset > RX8025_ADJ_DATA_MAX)
@@ -449,11 +448,7 @@ static int rx8025_set_offset(struct device *dev, long offset)
offset += 128;
digoff = offset;

- err = rx8025_write_reg(client, RX8025_REG_DIGOFF, digoff);
- if (err)
- return err;
-
- return 0;
+ return rx8025_write_reg(client, RX8025_REG_DIGOFF, digoff);
}

static const struct rtc_class_ops rx8025_rtc_ops = {
--
2.25.1

2022-05-10 17:29:50

by Nobuhiro Iwamatsu

Subject: Re: [PATCH] rtc: simplify the return expression of rx8025_set_offset()

Hi,

2022年5月5日(木) 11:23 <[email protected]>:
>
> From: Minghao Chi <[email protected]>
>
> Simplify the return expression.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Minghao Chi <[email protected]>
> ---
> drivers/rtc/rtc-rx8025.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)

Reviewed-by: Nobuhiro Iwamatsu <[email protected]>

Best regards,
Nobuhiro

--
Nobuhiro Iwamatsu
iwamatsu at {nigauri.org / debian.org / kernel.org}
GPG ID: 40AD1FA6

2022-05-18 04:51:43

by Alexandre Belloni

Subject: Re: [PATCH] rtc: simplify the return expression of rx8025_set_offset()

On Thu, 5 May 2022 02:23:14 +0000, [email protected] wrote:
> From: Minghao Chi <[email protected]>
>
> Simplify the return expression.
>
>

Applied, thanks!

[1/1] rtc: simplify the return expression of rx8025_set_offset()
commit: bce7a01ada6456d00c69cd816357ded268ad780c

Best regards,

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com